Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sensitive_params to bigquery_data_transfer_config #3937

Merged

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Sep 1, 2020

Fixes hashicorp/terraform-provider-google#7125

I tested this locally, but not sure I can add a test in since it would require AWS credentials.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigquerydatatransfer: fixed `params.secret_access_key` perma-diff for AWS S3 data transfer config types by adding a `sensitive_params` block with the `secret_access_key` attribute.

@google-cla google-cla bot added the cla: yes label Sep 1, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 124 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 2 files changed, 124 insertions(+), 20 deletions(-))
TF Conversion: Diff ( 1 file changed, 39 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=143836"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 126 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 2 files changed, 126 insertions(+), 20 deletions(-))
TF Conversion: Diff ( 1 file changed, 39 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=143837"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleNetblockIpRanges_basic|TestAccBigqueryDataTransferConfig|TestAccComputeDisk_VSSWindows You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=143838"

@megan07 megan07 force-pushed the megan_bigquery_transfer branch from a334a07 to 17e83a6 Compare September 1, 2020 15:48
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 116 insertions(+))
Terraform Beta: Diff ( 2 files changed, 116 insertions(+))
TF Conversion: Diff ( 1 file changed, 39 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=143841"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleNetblockIpRanges_basic|TestAccComputeDisk_VSSWindows You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=143843"

@megan07 megan07 requested a review from slevenick September 1, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource google_bigquery_data_transfer_config for S3 transfer always produce diff in terraform's plan
3 participants