-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sensitive_params to bigquery_data_transfer_config #3937
add sensitive_params to bigquery_data_transfer_config #3937
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 124 insertions(+), 20 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=143836" |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 126 insertions(+), 20 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=143837" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleNetblockIpRanges_basic|TestAccBigqueryDataTransferConfig|TestAccComputeDisk_VSSWindows You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=143838" |
a334a07
to
17e83a6
Compare
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=143841" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleNetblockIpRanges_basic|TestAccComputeDisk_VSSWindows You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=143843" |
Fixes hashicorp/terraform-provider-google#7125
I tested this locally, but not sure I can add a test in since it would require AWS credentials.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)