add desc to schema for google_dataflow_job #3644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @SirGitsalot, please review this PR or find an appropriate assignee. |
|
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=120644" |
megan07
approved these changes
Jun 22, 2020
| }, | ||
|
|
||
| "zone": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| // ForceNew applies to both stream and batch jobs | ||
| ForceNew: true, | ||
| ForceNew: true, | ||
| Description: `The zone in which the created job should run. If it is not provided, the provider zone is used.`, | ||
| }, | ||
|
|
||
| "region": { |
There was a problem hiding this comment.
Should this be added to the website documentation as well?
There was a problem hiding this comment.
region is not listed in https://cloud.google.com/dataflow/docs/reference/rest/v1b3/projects.jobs. Decided not add it in the website doc.
This was referenced Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of hashicorp/terraform-provider-google#6105
Release Note Template for Downstream PRs (will be copied)