Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding cpu_overcommit_type and updating tests #3640

Merged
merged 2 commits into from
Jun 16, 2020

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Jun 15, 2020

I think this should have been implemented as part of hashicorp/terraform-provider-google#5416

I also hard-coded the tests because the need to be type n1/n2 and this will guarantee that they are.

Fixes hashicorp/terraform-provider-google#6591

Also, I put the test for this in ComputeInstance tests because it made sense, but if you think i should have a separate test in the node template tests, I can do that too.

Release Note Template for Downstream PRs (will be copied)

compute: added `cpu_over_commit_type` to `google_compute_node_template`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 3 files changed, 38 insertions(+), 10 deletions(-))
Inspec: Diff ( 4 files changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=120549"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 3 files changed, 38 insertions(+), 10 deletions(-))
Inspec: Diff ( 4 files changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=120779"

@megan07 megan07 requested a review from rileykarson June 16, 2020 15:11
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable place for the test to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix TestAccComputeInstance_soleTenantNodeAffinities test
4 participants