-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add monitoring group mutex to uptime check config #3584
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 13 files changed, 40 insertions(+), 31 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 14 files changed, 54 insertions(+), 32 deletions(-)) |
log.Printf("[WARN] Removing %s because it's gone", resource) | ||
// The resource doesn't exist anymore | ||
d.SetId("") | ||
|
||
return nil | ||
} | ||
|
||
return fmt.Errorf("Error reading %s: %s", resource, err) | ||
return errwrap.Wrapf( | ||
fmt.Sprintf("Error when reading or editing %s: {{err}}", resource), err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was so confusing when we were debugging, but the handleNotFound error is also called during non-read
@@ -79,15 +79,16 @@ func getRouterLockName(region string, router string) string { | |||
} | |||
|
|||
func handleNotFoundError(err error, d *schema.ResourceData, resource string) error { | |||
if isGoogleApiErrorWithCode(err, 404) { | |||
if isGoogleApiErrorWithCode(err, 404) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if isGoogleApiErrorWithCode(err, 404) { | |
if isGoogleApiErrorWithCode(err, 404) { |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 14 files changed, 54 insertions(+), 32 deletions(-)) |
Release Note Template for Downstream PRs (will be copied)
Fixes hashicorp/terraform-provider-google#6452
Related: