Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monitoring group mutex to uptime check config #3584

Merged
merged 3 commits into from
Jun 1, 2020

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented May 29, 2020

Release Note Template for Downstream PRs (will be copied)


Fixes hashicorp/terraform-provider-google#6452

Related:

  • b/157746942

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 13 files changed, 40 insertions(+), 31 deletions(-))
Terraform Beta: Diff ( 13 files changed, 40 insertions(+), 31 deletions(-))
TF Conversion: Diff ( 1 file changed, 10 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))

@emilymye emilymye changed the title Add error predicate for flaky monitoring 400 in tests with groups Add monitoring group mutex to uptime check config May 29, 2020
@emilymye emilymye requested a review from c2thorn May 29, 2020 17:32
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 14 files changed, 54 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 14 files changed, 54 insertions(+), 32 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 2 deletions(-))

log.Printf("[WARN] Removing %s because it's gone", resource)
// The resource doesn't exist anymore
d.SetId("")

return nil
}

return fmt.Errorf("Error reading %s: %s", resource, err)
return errwrap.Wrapf(
fmt.Sprintf("Error when reading or editing %s: {{err}}", resource), err)
Copy link
Contributor Author

@emilymye emilymye May 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was so confusing when we were debugging, but the handleNotFound error is also called during non-read

@@ -79,15 +79,16 @@ func getRouterLockName(region string, router string) string {
}

func handleNotFoundError(err error, d *schema.ResourceData, resource string) error {
if isGoogleApiErrorWithCode(err, 404) {
if isGoogleApiErrorWithCode(err, 404) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if isGoogleApiErrorWithCode(err, 404) {
if isGoogleApiErrorWithCode(err, 404) {

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 14 files changed, 54 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 14 files changed, 54 insertions(+), 32 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 2 deletions(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error 400 when calling destroy with alert policy and monitoring group in the plan
4 participants