Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #6436 #3550

Merged
merged 1 commit into from
May 21, 2020
Merged

Conversation

edwardmedia
Copy link
Contributor

@edwardmedia edwardmedia commented May 21, 2020

Fixes hashicorp/terraform-provider-google#6436

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rambleraptor, please review this PR or find an appropriate assignee.

@edwardmedia edwardmedia requested review from slevenick and removed request for rambleraptor May 21, 2020 18:29
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is unfortunate. The decoder had a custom id format that I didn't update

@edwardmedia edwardmedia merged commit 5f8036f into GoogleCloudPlatform:master May 21, 2020
@edwardmedia edwardmedia deleted the issue6436 branch May 21, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_spanner_database.id format inconsistent with docs
4 participants