Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more VCR tests #3531

Merged
merged 7 commits into from
May 21, 2020

Conversation

slevenick
Copy link
Contributor

Migrate more tests (that were added recently) to use VCR.

Ignore several tests that cannot pass due to various reasons

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 13 files changed, 30 insertions(+), 17 deletions(-))
Terraform Beta: Diff ( 18 files changed, 36 insertions(+), 24 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 13 files changed, 31 insertions(+), 18 deletions(-))
Terraform Beta: Diff ( 19 files changed, 38 insertions(+), 26 deletions(-))

@slevenick slevenick requested a review from danawillow May 19, 2020 17:54
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 13 files changed, 33 insertions(+), 18 deletions(-))
Terraform Beta: Diff ( 19 files changed, 40 insertions(+), 26 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 14 files changed, 34 insertions(+), 18 deletions(-))
Terraform Beta: Diff ( 20 files changed, 41 insertions(+), 26 deletions(-))

@@ -12,6 +12,8 @@ import (
)

func TestAccKmsSecret_basic(t *testing.T) {
// Nested tests confuse VCR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you file an issue to fix this?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 53 insertions(+), 18 deletions(-))
Terraform Beta: Diff ( 21 files changed, 60 insertions(+), 26 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 61 insertions(+), 18 deletions(-))
Terraform Beta: Diff ( 21 files changed, 68 insertions(+), 26 deletions(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants