Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ids #1 in manual docs (part 4 of #5542) #3489

Merged
merged 28 commits into from
May 11, 2020

Conversation

edwardmedia
Copy link
Contributor

@edwardmedia edwardmedia commented May 8, 2020

Fixes hashicorp/terraform-provider-google#5542

Release Note Template for Downstream PRs (will be copied)


edward and others added 28 commits February 19, 2020 15:20
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@SirGitsalot, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 75 files changed, 377 insertions(+), 329 deletions(-))
Terraform Beta: Diff ( 79 files changed, 460 insertions(+), 412 deletions(-))
TF OiCS: Diff ( 44 files changed, 186 insertions(+), 186 deletions(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document id field for resources
5 participants