Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry for storage bucket 412 #3434

Merged
merged 2 commits into from
Apr 28, 2020

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented Apr 28, 2020

Release Note Template for Downstream PRs (will be copied)

storage: Added retries for `google_storage_bucket_iam_*` on 412 (precondition not met) errors for eventually consistent bucket creation.

(Should) Fix hashicorp/terraform-provider-google#6212

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 7 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 7 insertions(+))

@emilymye emilymye requested a review from danawillow April 28, 2020 03:44
@preston-hf
Copy link

I think this ultimately doesn't fix the issue and causes a greater one (deadlock): hashicorp/terraform-provider-google#6833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bucket resource returns as completed before it actually exists
5 participants