Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add min_cpu_platform to google_container_cluster.cluster_autoscaling.auto_provisioning_defaults #3383

Merged
merged 1 commit into from
May 19, 2020

Conversation

danawillow
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#5947

Release Note Template for Downstream PRs (will be copied)

* container: added `min_cpu_platform` to google_container_cluster.cluster_autoscaling.auto_provisioning_defaults [beta-only]

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 84 insertions(+), 2 deletions(-))

@danawillow
Copy link
Contributor Author

Note: do not submit or test until b/154174834 is resolved.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 93 insertions(+), 2 deletions(-))

@danawillow danawillow requested a review from c2thorn May 19, 2020 17:42
Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad the internal issue is resolved! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for MinCPUPlatform in auto_provisioning_defaults
4 participants