Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ipv4_enabled default to true #3330

Merged

Conversation

danawillow
Copy link
Contributor

@danawillow danawillow commented Apr 2, 2020

Fixes hashicorp/terraform-provider-google#6012.

Adding a default value will only affect people who had already provisioned instances that did not set a value for that field. If they're a second gen user, the server-side default is true, so their state would already have this value set as true. First gen instances have been decommissioned, so there should be ~0 terraform users using them.

Release Note Template for Downstream PRs (will be copied)

* sql: fixed error that occurred on `google_sql_database_instance` when `settings.ip_configuration` was set but `ipv4_enabled` was not set to true and `private_network` was not configured, by defaulting `ipv4_enabled` to true.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 3 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 2 files changed, 3 insertions(+), 5 deletions(-))

@danawillow danawillow requested a review from megan07 April 2, 2020 20:04
@danawillow danawillow merged commit aecf1bc into GoogleCloudPlatform:master Apr 3, 2020
@danawillow danawillow deleted the tf-6012-sql-ipv4-enabled branch April 3, 2020 17:16
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_sql_database_instance inconsistent defaulting for ipv4_enabled
4 participants