Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA google_container_cluster maintenance policy recurring window #3288

Merged
merged 4 commits into from
Mar 24, 2020

Conversation

slevenick
Copy link
Contributor

Requested in hashicorp/terraform-provider-google#5391

release_channel is not yet GA, so this only fixes half of that request

Release Note Template for Downstream PRs (will be copied)

container: Added field `maintenance_policy.recurring_window` to  `google_container_cluster` (GA only)

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 108 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 2 files changed, 2 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 129 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 10 insertions(+), 14 deletions(-))
TF Conversion: Diff ( 1 file changed, 8 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 153 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 10 insertions(+), 14 deletions(-))
TF Conversion: Diff ( 1 file changed, 8 insertions(+))

@slevenick slevenick requested a review from rileykarson March 23, 2020 22:03
@slevenick slevenick merged commit d74682b into GoogleCloudPlatform:master Mar 24, 2020
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
…leCloudPlatform#3288)

* GA release_channel and maintenance window recurring policy

* Un GA release_channel, it is not ga

* Move validate to validation.go, GA diff suppress too

* Ga test too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants