Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream terraform-provider-google-beta#1766 #3178

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented Feb 27, 2020

Upstream https://github.com/terraform-providers/terraform-provider-google-beta/pull/1766/files

Fixes hashicorp/terraform-provider-google#5768

Release Note Template for Downstream PRs (will be copied)

container: Fixed panic when upgrading `google_container_cluster` with autoscaling block 

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 1 file changed, 3 insertions(+), 1 deletion(-))

@emilymye emilymye requested a review from chrisst February 27, 2020 02:18
@emilymye
Copy link
Contributor Author

@chrisst @megan07 i kinda want to cherrypick this into next release if possible

@emilymye emilymye requested a review from megan07 February 27, 2020 03:03
@emilymye emilymye changed the title Add nil check for autoscaling profile Upstream terraform-provider-google-beta#1766 Feb 27, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 7 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 7 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 7 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 7 insertions(+), 2 deletions(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault in google_container_cluster since 3.10.0
4 participants