Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set public_key to computed #3095

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Feb 7, 2020

Fixes hashicorp/terraform-provider-google#5552
Fixes hashicorp/terraform-provider-google#5219

google_kms_crypto_key_version: public_key was not set to computed, so terraform did not wait for the datasource to resolve before complaining that the list was empty. The original documentation implies that this field was meant to be implemented as computed.

Release Note Template for Downstream PRs (will be copied)

kms: Fixed issue where `google_kms_crypto_key_version` datasource would throw an Invalid Index error on plan

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@c2thorn c2thorn requested a review from rileykarson February 7, 2020 22:13
@c2thorn c2thorn merged commit 16bb81b into GoogleCloudPlatform:master Feb 7, 2020
@c2thorn c2thorn deleted the crypto-key-version-fix branch February 7, 2020 22:23
@c2thorn c2thorn restored the crypto-key-version-fix branch February 13, 2020 23:23
@c2thorn c2thorn deleted the crypto-key-version-fix branch February 13, 2020 23:44
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants