Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve storage bucket acls #2955

Merged

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented Jan 10, 2020

Stop the project-owner- from showing up in a diff indicating that it will be removed since we intentionally strip it from the list of acl's to remove.

fixes hashicorp/terraform-provider-google#4405

Release Note Template for Downstream PRs (will be copied)

storage: Stopped `project-owner` showing up in the diff for `google_storage_bucket_acl` as it won't be removed.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 940093c.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1625
depends: hashicorp/terraform-provider-google#5372
depends: ansible-collections/google.cloud#131

chrisst and others added 3 commits January 22, 2020 02:17
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 571c369 into GoogleCloudPlatform:master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_storage_bucket_acl takes authoritative control after first apply
4 participants