Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote Router Route Policies to GA #13239

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

amanMahendroo
Copy link
Contributor

@amanMahendroo amanMahendroo commented Mar 1, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

google_compute_router_route_policy (GA)

@github-actions github-actions bot requested a review from slevenick March 1, 2025 06:51
Copy link

github-actions bot commented Mar 1, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1358 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 4 files changed, 259 insertions(+), 30 deletions(-))
Open in Cloud Shell: Diff ( 8 files changed, 268 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccComputeRouterRoutePolicy_routerRoutePolicyExportExampleUpdate
  • TestAccComputeRouterRoutePolicy_routerRoutePolicyImportExampleUpdate

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccComputeRouterRoutePolicy_routerRoutePolicyExportExample
  • TestAccComputeRouterRoutePolicy_routerRoutePolicyImportExample
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1353 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 4 files changed, 254 insertions(+), 30 deletions(-))
Open in Cloud Shell: Diff ( 8 files changed, 268 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1126
Passed tests: 1045
Skipped tests: 79
Affected tests: 2

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccComputeRouterRoutePolicy_routerRoutePolicyExportExample
  • TestAccComputeRouterRoutePolicy_routerRoutePolicyImportExample

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouterRoutePolicy_routerRoutePolicyExportExampleUpdate
  • TestAccComputeRouterRoutePolicy_routerRoutePolicyImportExampleUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeRouterRoutePolicy_routerRoutePolicyExportExampleUpdate [Error message] [Debug log]
TestAccComputeRouterRoutePolicy_routerRoutePolicyImportExampleUpdate [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants