artifactregistry: fix cleanup policies updates

[Subserial]

Fixes hashicorp/terraform-provider-google#21348

The original fix panicked on type assertion failures and incorrectly hashed objects. Turns out, for objects in Maps (stored as sets) the diff suppress func doesn't matter as the values hash differently. This change moves the diff suppress functionality to the hashing step.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

artifactregistry: fixed failing update when changing cleanup policies in `google_artifact_registry_repository`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 53 insertions(+), 29 deletions(-))
google-beta provider: Diff ( 1 file changed, 53 insertions(+), 29 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 47 insertions(+), 21 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field cleanup_policies.condition.newer_than lost its diff suppress function - reference
• Field cleanup_policies.condition.older_than lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 31
Passed tests: 30
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• artifactregistry

🟢 All tests passed!

View the build log