Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new resource IAM OAuth Client Credential for Workforce Identity Federation #13231

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

plus-1s
Copy link
Contributor

@plus-1s plus-1s commented Feb 28, 2025

Add new resource IAM OAuth Client Credential for Workforce Identity Federation.
Public documentation: https://cloud.google.com/iam/docs/workforce-manage-oauth-app#manage-clients
API: https://cloud.google.com/iam/docs/reference/rest/v1/projects.locations.oauthClients.credentials

Fixes hashicorp/terraform-provider-google#20225

`google_iam_oauth_client_credential`

@plus-1s plus-1s changed the title Add new resource IAM OAuth Client Credential for Workforce Identity Federation.Credential Add new resource IAM OAuth Client Credential for Workforce Identity Federation Feb 28, 2025
@plus-1s plus-1s force-pushed the credential branch 2 times, most recently from b9e8a26 to fafdc4a Compare February 28, 2025 10:11
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 2191 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 11 files changed, 2191 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 258 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 454 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

  • google_iam_oauth_client
  • google_iam_oauth_client_credential

If you believe this detection to be incorrect please raise the concern with your reviewer.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 23
Passed tests: 15
Skipped tests: 0
Affected tests: 8

Click here to see the affected service packages
  • iamworkforcepool

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAMWorkforcePoolOauthClientCredential_basic
  • TestAccIAMWorkforcePoolOauthClientCredential_full
  • TestAccIAMWorkforcePoolOauthClientCredential_iamOauthClientCredentialBasicExample
  • TestAccIAMWorkforcePoolOauthClientCredential_iamOauthClientCredentialFullExample
  • TestAccIAMWorkforcePoolOauthClient_basic
  • TestAccIAMWorkforcePoolOauthClient_full
  • TestAccIAMWorkforcePoolOauthClient_iamOauthClientBasicExample
  • TestAccIAMWorkforcePoolOauthClient_iamOauthClientFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccIAMWorkforcePoolOauthClientCredential_basic [Debug log]
TestAccIAMWorkforcePoolOauthClientCredential_full [Debug log]
TestAccIAMWorkforcePoolOauthClient_basic [Debug log]
TestAccIAMWorkforcePoolOauthClient_full [Debug log]
TestAccIAMWorkforcePoolOauthClient_iamOauthClientBasicExample [Debug log]
TestAccIAMWorkforcePoolOauthClient_iamOauthClientFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccIAMWorkforcePoolOauthClientCredential_iamOauthClientCredentialBasicExample [Error message] [Debug log]
TestAccIAMWorkforcePoolOauthClientCredential_iamOauthClientCredentialFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 2191 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 11 files changed, 2191 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 258 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 454 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

  • google_iam_oauth_client
  • google_iam_oauth_client_credential

If you believe this detection to be incorrect please raise the concern with your reviewer.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 23
Passed tests: 19
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • iamworkforcepool

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAMWorkforcePoolOauthClientCredential_basic
  • TestAccIAMWorkforcePoolOauthClientCredential_full
  • TestAccIAMWorkforcePoolOauthClientCredential_iamOauthClientCredentialBasicExample
  • TestAccIAMWorkforcePoolOauthClientCredential_iamOauthClientCredentialFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccIAMWorkforcePoolOauthClientCredential_basic [Debug log]
TestAccIAMWorkforcePoolOauthClientCredential_full [Debug log]
TestAccIAMWorkforcePoolOauthClientCredential_iamOauthClientCredentialBasicExample [Debug log]
TestAccIAMWorkforcePoolOauthClientCredential_iamOauthClientCredentialFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 2191 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 11 files changed, 2191 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 258 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 454 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 23
Passed tests: 23
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • iamworkforcepool

🟢 All tests passed!

View the build log

@plus-1s plus-1s marked this pull request as ready for review March 1, 2025 18:30
Copy link

github-actions bot commented Mar 1, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 998 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 998 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 103 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 233 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 23
Passed tests: 23
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • iamworkforcepool

🟢 All tests passed!

View the build log

@plus-1s plus-1s force-pushed the credential branch 3 times, most recently from 585a0a7 to 2692d91 Compare March 2, 2025 19:01
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 1004 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 8 files changed, 1004 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 103 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 233 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 23
Passed tests: 23
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • iamworkforcepool

🟢 All tests passed!

View the build log

@plus-1s plus-1s force-pushed the credential branch 3 times, most recently from 5664a7d to b6f2f41 Compare March 2, 2025 19:55
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 984 insertions(+), 26 deletions(-))
google-beta provider: Diff ( 8 files changed, 984 insertions(+), 26 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 81 insertions(+), 24 deletions(-))
Open in Cloud Shell: Diff ( 8 files changed, 233 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 984 insertions(+), 26 deletions(-))
google-beta provider: Diff ( 8 files changed, 984 insertions(+), 26 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 81 insertions(+), 24 deletions(-))
Open in Cloud Shell: Diff ( 8 files changed, 233 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 19
Passed tests: 18
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • iamworkforcepool
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccIAMWorkforcePoolOauthClientCredential_basic
  • TestAccIAMWorkforcePoolOauthClientCredential_full
  • TestAccIAMWorkforcePoolOauthClientCredential_iamOauthClientCredentialFullExample

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAMWorkforcePoolOauthClientCredential_iamOauthClientCredentialBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 14
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • iamworkforcepool
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccIAMWorkforcePoolOauthClientCredential_basic
  • TestAccIAMWorkforcePoolOauthClientCredential_full
  • TestAccIAMWorkforcePoolOauthClientCredential_iamOauthClientCredentialFullExample

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAMWorkforcePoolOauthClientCredential_iamOauthClientCredentialBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccIAMWorkforcePoolOauthClientCredential_iamOauthClientCredentialBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccIAMWorkforcePoolOauthClientCredential_iamOauthClientCredentialBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Resource projects.location.oauthClient
2 participants