Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terraform support for glossary category #13230

Closed

Conversation

Sachin-Rungta
Copy link
Member

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from shuyama1 February 28, 2025 08:13
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1715 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 1715 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 504 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_category_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_category_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_dataplex_category_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_category_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 49
Passed tests: 44
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages
  • dataplex

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexCategoryIamBindingGenerated
  • TestAccDataplexCategoryIamMemberGenerated
  • TestAccDataplexCategoryIamPolicyGenerated
  • TestAccDataplexCategory_dataplexCategoryBasicExample
  • TestAccDataplexCategory_dataplexCategoryFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataplexCategoryIamBindingGenerated [Error message] [Debug log]
TestAccDataplexCategoryIamMemberGenerated [Error message] [Debug log]
TestAccDataplexCategoryIamPolicyGenerated [Error message] [Debug log]
TestAccDataplexCategory_dataplexCategoryBasicExample [Error message] [Debug log]
TestAccDataplexCategory_dataplexCategoryFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants