-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote CSM network services resources to GA #13206
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @maphad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
I am currently reviewing this pull request. In the meanwhile, I am providing a summary of the content of the pull request for you and other reviewers to get up to speed quickly on the changes that have occurred, and the intent behind these changes.
This pull request promotes several CSM network services resources from beta to GA (Generally Available). The resources being promoted are network_services_mesh
, network_services_http_route
, network_services_grpc_route
, network_services_tcp_route
, network_services_tls_route
, network_services_service_binding
, and network_services_endpoint_policy
. The changes involve removing the min_version: beta
attribute from the resource definitions in the mmv1
directory, as well as removing provider = google-beta
from terraform examples.
Highlights
- GA Promotion: Promotes network services resources to GA by removing
min_version: beta
from resource definitions. - Resource Definitions: Modifies YAML files in
mmv1/products/networkservices/
to remove beta versioning. - Terraform Examples: Updates Terraform example templates to remove the explicit
google-beta
provider specification.
Changelog
Click here to see the changelog
- mmv1/products/networkservices/EndpointPolicy.yaml
- Removed
min_version: beta
from the main resource definition. - Removed
min_version: beta
from example definitions. - Removed
min_version: beta
from the 'name' parameter. - Removed
min_version: beta
from the 'createTime' property. - Removed
min_version: beta
from the 'updateTime' property. - Removed
min_version: beta
from the 'labels' property. - Removed
min_version: beta
from the 'description' property. - Removed
min_version: beta
from the 'authorizationPolicy' property. - Removed
min_version: beta
from the 'serverTlsPolicy' property. - Removed
min_version: beta
from the 'clientTlsPolicy' property. - Removed
min_version: beta
from the 'type' property. - Removed
min_version: beta
from the 'port' property. - Removed
min_version: beta
from the 'endpointMatcher' property. - Removed
min_version: beta
from the 'metadataLabelMatcher' property. - Removed
min_version: beta
from the 'metadataLabelMatchCriteria' property. - Removed
min_version: beta
from the 'metadataLabels' property. - Removed
min_version: beta
from the 'labelName' property. - Removed
min_version: beta
from the 'labelValue' property.
- Removed
- mmv1/products/networkservices/GrpcRoute.yaml
- Removed
min_version: beta
from the main resource definition. - Removed
min_version: beta
from example definitions. - Removed
min_version: beta
from the 'name' parameter. - Removed
min_version: beta
from the 'selfLink' property. - Removed
min_version: beta
from the 'createTime' property. - Removed
min_version: beta
from the 'updateTime' property. - Removed
min_version: beta
from the 'labels' property. - Removed
min_version: beta
from the 'description' property. - Removed
min_version: beta
from the 'hostnames' property. - Removed
min_version: beta
from the 'meshes' property. - Removed
min_version: beta
from the 'gateways' property. - Removed
min_version: beta
from the 'rules' property. - Removed
min_version: beta
from the 'matches' property. - Removed
min_version: beta
from the 'headers' property. - Removed
min_version: beta
from the 'key' property. - Removed
min_version: beta
from the 'value' property. - Removed
min_version: beta
from the 'type' property. - Removed
min_version: beta
from the 'grpcService' property. - Removed
min_version: beta
from the 'grpcMethod' property. - Removed
min_version: beta
from the 'caseSensitive' property. - Removed
min_version: beta
from the 'action' property. - Removed
min_version: beta
from the 'destinations' property. - Removed
min_version: beta
from the 'serviceName' property. - Removed
min_version: beta
from the 'weight' property. - Removed
min_version: beta
from the 'faultInjectionPolicy' property. - Removed
min_version: beta
from the 'delay' property. - Removed
min_version: beta
from the 'fixedDelay' property. - Removed
min_version: beta
from the 'percentage' property. - Removed
min_version: beta
from the 'abort' property. - Removed
min_version: beta
from the 'httpStatus' property. - Removed
min_version: beta
from the 'timeout' property. - Removed
min_version: beta
from the 'retryPolicy' property. - Removed
min_version: beta
from the 'retryConditions' property. - Removed
min_version: beta
from the 'numRetries' property.
- Removed
- mmv1/products/networkservices/HttpRoute.yaml
- Removed
min_version: beta
from the main resource definition. - Removed
min_version: beta
from example definitions. - Removed
min_version: beta
from the 'name' parameter. - Removed
min_version: beta
from the 'selfLink' property. - Removed
min_version: beta
from the 'createTime' property. - Removed
min_version: beta
from the 'updateTime' property. - Removed
min_version: beta
from the 'labels' property. - Removed
min_version: beta
from the 'description' property. - Removed
min_version: beta
from the 'hostnames' property. - Removed
min_version: beta
from the 'meshes' property. - Removed
min_version: beta
from the 'gateways' property. - Removed
min_version: beta
from the 'rules' property. - Removed
min_version: beta
from the 'matches' property. - Removed
min_version: beta
from the 'caseSensitive' property. - Removed
min_version: beta
from the 'fullPathMatch' property. - Removed
min_version: beta
from the 'prefixMatch' property. - Removed
min_version: beta
from the 'regexMatch' property. - Removed
min_version: beta
from the 'queryParameters' property. - Removed
min_version: beta
from the 'queryParameter' property. - Removed
min_version: beta
from the 'exactMatch' property. - Removed
min_version: beta
from the 'regexMatch' property. - Removed
min_version: beta
from the 'presentMatch' property. - Removed
min_version: beta
from the 'headers' property. - Removed
min_version: beta
from the 'header' property. - Removed
min_version: beta
from the 'invertMatch' property. - Removed
min_version: beta
from the 'exactMatch' property. - Removed
min_version: beta
from the 'regexMatch' property. - Removed
min_version: beta
from the 'prefixMatch' property. - Removed
min_version: beta
from the 'presentMatch' property. - Removed
min_version: beta
from the 'suffixMatch' property. - Removed
min_version: beta
from the 'rangeMatch' property. - Removed
min_version: beta
from the 'start' property. - Removed
min_version: beta
from the 'end' property. - Removed
min_version: beta
from the 'action' property. - Removed
min_version: beta
from the 'destinations' property. - Removed
min_version: beta
from the 'serviceName' property. - Removed
min_version: beta
from the 'weight' property. - Removed
min_version: beta
from the 'redirect' property. - Removed
min_version: beta
from the 'hostRedirect' property. - Removed
min_version: beta
from the 'pathRedirect' property. - Removed
min_version: beta
from the 'prefixRewrite' property. - Removed
min_version: beta
from the 'responseCode' property. - Removed
min_version: beta
from the 'httpsRedirect' property. - Removed
min_version: beta
from the 'stripQuery' property. - Removed
min_version: beta
from the 'portRedirect' property. - Removed
min_version: beta
from the 'faultInjectionPolicy' property. - Removed
min_version: beta
from the 'delay' property. - Removed
min_version: beta
from the 'fixedDelay' property. - Removed
min_version: beta
from the 'percentage' property. - Removed
min_version: beta
from the 'abort' property. - Removed
min_version: beta
from the 'httpStatus' property. - Removed
min_version: beta
from the 'requestHeaderModifier' property. - Removed
min_version: beta
from the 'set' property. - Removed
min_version: beta
from the 'add' property. - Removed
min_version: beta
from the 'remove' property. - Removed
min_version: beta
from the 'responseHeaderModifier' property. - Removed
min_version: beta
from the 'set' property. - Removed
min_version: beta
from the 'add' property. - Removed
min_version: beta
from the 'remove' property. - Removed
min_version: beta
from the 'urlRewrite' property. - Removed
min_version: beta
from the 'pathPrefixRewrite' property. - Removed
min_version: beta
from the 'hostRewrite' property. - Removed
min_version: beta
from the 'timeout' property. - Removed
min_version: beta
from the 'retryPolicy' property. - Removed
min_version: beta
from the 'retryConditions' property. - Removed
min_version: beta
from the 'numRetries' property. - Removed
min_version: beta
from the 'perTryTimeout' property. - Removed
min_version: beta
from the 'requestMirrorPolicy' property. - Removed
min_version: beta
from the 'destination' property. - Removed
min_version: beta
from the 'serviceName' property. - Removed
min_version: beta
from the 'weight' property. - Removed
min_version: beta
from the 'corsPolicy' property. - Removed
min_version: beta
from the 'allowOrigins' property. - Removed
min_version: beta
from the 'allowOriginRegexes' property. - Removed
min_version: beta
from the 'allowMethods' property. - Removed
min_version: beta
from the 'allowHeaders' property. - Removed
min_version: beta
from the 'exposeHeaders' property. - Removed
min_version: beta
from the 'maxAge' property. - Removed
min_version: beta
from the 'allowCredentials' property. - Removed
min_version: beta
from the 'disabled' property.
- Removed
- mmv1/products/networkservices/Mesh.yaml
- Removed
min_version: beta
from the main resource definition. - Removed
min_version: beta
from example definitions. - Removed
min_version: beta
from the 'name' parameter. - Removed
min_version: beta
from the 'selfLink' property. - Removed
min_version: beta
from the 'createTime' property. - Removed
min_version: beta
from the 'updateTime' property. - Removed
min_version: beta
from the 'labels' property. - Removed
min_version: beta
from the 'description' property. - Removed
min_version: beta
from the 'interceptionPort' property. - Removed
min_version: beta
from the 'location' property.
- Removed
- mmv1/products/networkservices/ServiceBinding.yaml
- Removed
min_version: beta
from the main resource definition. - Removed
min_version: beta
from example definitions. - Removed
min_version: beta
from the 'name' parameter. - Removed
min_version: beta
from the 'createTime' property. - Removed
min_version: beta
from the 'updateTime' property. - Removed
min_version: beta
from the 'labels' property. - Removed
min_version: beta
from the 'description' property. - Removed
min_version: beta
from the 'service' property.
- Removed
- mmv1/products/networkservices/TcpRoute.yaml
- Removed
min_version: beta
from the main resource definition. - Removed
min_version: beta
from example definitions. - Removed
min_version: beta
from the 'name' parameter. - Removed
min_version: beta
from the 'selfLink' property. - Removed
min_version: beta
from the 'createTime' property. - Removed
min_version: beta
from the 'updateTime' property. - Removed
min_version: beta
from the 'labels' property. - Removed
min_version: beta
from the 'description' property. - Removed
min_version: beta
from the 'meshes' property. - Removed
min_version: beta
from the 'gateways' property. - Removed
min_version: beta
from the 'rules' property. - Removed
min_version: beta
from the 'matches' property. - Removed
min_version: beta
from the 'sourceIpRanges' property. - Removed
min_version: beta
from the 'destinationPorts' property. - Removed
min_version: beta
from the 'action' property. - Removed
min_version: beta
from the 'destinations' property. - Removed
min_version: beta
from the 'serviceName' property. - Removed
min_version: beta
from the 'weight' property. - Removed
min_version: beta
from the 'originalDestination' property. - Removed
min_version: beta
from the 'idleTimeout' property.
- Removed
- mmv1/products/networkservices/TlsRoute.yaml
- Removed
min_version: beta
from the main resource definition. - Removed
min_version: beta
from example definitions. - Removed
min_version: beta
from the 'name' parameter. - Removed
min_version: beta
from the 'selfLink' property. - Removed
min_version: beta
from the 'createTime' property. - Removed
min_version: beta
from the 'updateTime' property. - Removed
min_version: beta
from the 'description' property. - Removed
min_version: beta
from the 'meshes' property. - Removed
min_version: beta
from the 'gateways' property. - Removed
min_version: beta
from the 'rules' property. - Removed
min_version: beta
from the 'matches' property. - Removed
min_version: beta
from the 'sniHosts' property. - Removed
min_version: beta
from the 'alpn' property. - Removed
min_version: beta
from the 'action' property. - Removed
min_version: beta
from the 'destinations' property. - Removed
min_version: beta
from the 'serviceName' property. - Removed
min_version: beta
from the 'weight' property.
- Removed
- mmv1/templates/terraform/examples/network_services_endpoint_policy_basic.tf.tmpl
- Removed
provider = google-beta
.
- Removed
- mmv1/templates/terraform/examples/network_services_endpoint_policy_empty_match.tf.tmpl
- Removed
provider = google-beta
.
- Removed
- mmv1/templates/terraform/examples/network_services_grpc_route_actions.tf.tmpl
- Removed
provider = google-beta
.
- Removed
- mmv1/templates/terraform/examples/network_services_grpc_route_basic.tf.tmpl
- Removed
provider = google-beta
.
- Removed
- mmv1/templates/terraform/examples/network_services_grpc_route_matches_and_actions.tf.tmpl
- Removed
provider = google-beta
.
- Removed
- mmv1/templates/terraform/examples/network_services_http_route_actions.tf.tmpl
- Removed
provider = google-beta
.
- Removed
- mmv1/templates/terraform/examples/network_services_http_route_basic.tf.tmpl
- Removed
provider = google-beta
.
- Removed
- mmv1/templates/terraform/examples/network_services_http_route_matches_and_actions.tf.tmpl
- Removed
provider = google-beta
.
- Removed
- mmv1/templates/terraform/examples/network_services_http_route_mesh_basic.tf.tmpl
- Removed
provider = google-beta
from both resources.
- Removed
- mmv1/templates/terraform/examples/network_services_mesh_basic.tf.tmpl
- Removed
provider = google-beta
.
- Removed
- mmv1/templates/terraform/examples/network_services_mesh_location.tf.tmpl
- Removed
provider = google-beta
.
- Removed
- mmv1/templates/terraform/examples/network_services_mesh_no_port.tf.tmpl
- Removed
provider = google-beta
.
- Removed
- mmv1/templates/terraform/examples/network_services_service_binding_basic.tf.tmpl
- Removed
provider = google-beta
from all resources.
- Removed
- mmv1/templates/terraform/examples/network_services_tcp_route_actions.tf.tmpl
- Removed
provider = google-beta
from all resources.
- Removed
- mmv1/templates/terraform/examples/network_services_tcp_route_basic.tf.tmpl
- Removed
provider = google-beta
from all resources.
- Removed
- mmv1/templates/terraform/examples/network_services_tcp_route_gateway_basic.tf.tmpl
- Removed
provider = google-beta
from all resources.
- Removed
- mmv1/templates/terraform/examples/network_services_tls_route_basic.tf.tmpl
- Removed
provider = google-beta
from all resources.
- Removed
- mmv1/templates/terraform/examples/network_services_tls_route_gateway_basic.tf.tmpl
- Removed
provider = google-beta
from all resources.
- Removed
- mmv1/templates/terraform/examples/network_services_tls_route_mesh_basic.tf.tmpl
- Removed
provider = google-beta
from all resources.
- Removed
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
From Beta's realm, to GA's light,
Network services take their flight.
No longer bound by version's chain,
Stability and trust they gain.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request promotes CSM network services resources to GA. The main change is removing the min_version: beta
from the yaml files. The release notes are well-written and informative.
Summary of Findings
- Redundant provider specification: The
provider = google-beta
line is redundant in the terraform example files since the provider is already specified at the top level.
Assessment
The pull request promotes CSM network services resources to GA by removing the min_version: beta
from the yaml files. The changes look good and the code is clear. I would recommend addressing the comments before requesting a review from someone else, but feel free to request another review from Gemini via /gemini review
when you have addressed these comments and I'll take another look! In any circumstance, users should have others review and approve this code before merging.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 58 Click here to see the affected service packages
🔴 Tests were added that are GA-only additions and require manual runs:
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 59 Click here to see the affected service packages
🔴 Tests were added that are GA-only additions and require manual runs:
View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 59 Click here to see the affected service packages
🔴 Tests were added that are GA-only additions and require manual runs:
View the build log |
Promote CSM network services resources from beta to GA
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.