Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Datastream connection profile for Salesforce #13195

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

matanmggl
Copy link
Member

@matanmggl matanmggl commented Feb 26, 2025

Adds Datastream connection profile for Salesforce.

Release Note Template for Downstream PRs (will be copied)

datastream: Add support for creating connection profiles for Salesforce. (beta)

@github-actions github-actions bot requested a review from c2thorn February 26, 2025 14:36
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 79 insertions(+))
google-beta provider: Diff ( 3 files changed, 431 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 155 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_datastream_connection_profile (11 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_connection_profile" "primary" {
  salesforce_profile {
    domain = # value needed
    oauth2_client_credentials {
      client_id                           = # value needed
      client_secret                       = # value needed
      secret_manager_stored_client_secret = # value needed
    }
    user_credentials {
      password                             = # value needed
      secret_manager_stored_password       = # value needed
      secret_manager_stored_security_token = # value needed
      security_token                       = # value needed
      username                             = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 4
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages
  • datastream

🟢 All tests passed!

View the build log

Copy link

github-actions bot commented Mar 3, 2025

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants