Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature gap: Add missed enable_flow_logs & state to subnetwork #13093

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Cezarus27
Copy link
Contributor

This patch introduces new fields to the Terraform provider for the subnetwork resource:

  • enable_flow_logs - a field that allows enabling flow logs. If the log_config field is not set in the configuration, the default log_config value returned by the API will be stored in tfstate.
  • state - a read-only field. During testing, it was observed that the API does not return this field in response to a GET request. Nevertheless, the field is stored in tfstate as an empty string.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `enable_flow_logs` and `state` fields to `google_compute_subnetwork` resource

@github-actions github-actions bot requested a review from trodge February 17, 2025 18:20
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 17, 2025
Copy link

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician added service/compute-vpc and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Feb 25, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 285 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 4 files changed, 285 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 26 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_subnetwork (543 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_subnetwork" "primary" {
  enable_flow_logs = # value needed
}

@trodge
Copy link
Contributor

trodge commented Feb 25, 2025

/gcbrun

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 25, 2025
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1121
Passed tests: 1039
Skipped tests: 77
Affected tests: 5

Click here to see the affected service packages
  • compute

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeSubnetwork_enableFlowLogs
  • TestAccComputeSubnetwork_flowLogs
  • TestAccComputeSubnetwork_flowLogsMigrate
  • TestAccComputeSubnetwork_ipv6
  • TestAccComputeSubnetwork_subnetworkLoggingConfigExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeSubnetwork_enableFlowLogs [Debug log]
TestAccComputeSubnetwork_flowLogs [Debug log]
TestAccComputeSubnetwork_flowLogsMigrate [Debug log]
TestAccComputeSubnetwork_ipv6 [Debug log]
TestAccComputeSubnetwork_subnetworkLoggingConfigExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccComputeSubnetwork_enableFlowLogs [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 25, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 285 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 4 files changed, 285 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 26 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_subnetwork (543 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_subnetwork" "primary" {
  enable_flow_logs = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1121
Passed tests: 1043
Skipped tests: 77
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeSubnetwork_enableFlowLogs

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeSubnetwork_enableFlowLogs [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccComputeSubnetwork_enableFlowLogs [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🟢 All tests passed!

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from trodge February 27, 2025 07:41
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 27, 2025
Copy link

github-actions bot commented Mar 3, 2025

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/compute-vpc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants