-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature gap: Add missed enable_flow_logs
& state
to subnetwork
#13093
base: main
Are you sure you want to change the base?
Feature gap: Add missed enable_flow_logs
& state
to subnetwork
#13093
Conversation
Signed-off-by: Cezary Sobczak <[email protected]>
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Signed-off-by: Cezary Sobczak <[email protected]>
Signed-off-by: Cezary Sobczak <[email protected]>
@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_subnetwork" "primary" {
enable_flow_logs = # value needed
}
|
/gcbrun |
Tests analyticsTotal tests: 1121 Click here to see the affected service packages
Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🟢 All tests passed! |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_subnetwork" "primary" {
enable_flow_logs = # value needed
}
|
Tests analyticsTotal tests: 1121 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🟢 All tests passed! |
mmv1/third_party/terraform/services/compute/resource_compute_subnetwork_test.go.tmpl
Outdated
Show resolved
Hide resolved
Signed-off-by: Cezary Sobczak <[email protected]>
@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
This patch introduces new fields to the Terraform provider for the
subnetwork
resource:enable_flow_logs
- a field that allows enabling flow logs. If thelog_config
field is not set in the configuration, the defaultlog_config
value returned by the API will be stored intfstate
.state
- a read-only field. During testing, it was observed that the API does not return this field in response to a GET request. Nevertheless, the field is stored intfstate
as an empty string.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.