Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mw valkey terraform changes #13049

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

meghakumgoogler
Copy link
Member

Valkey maintenance policy and schedule addition

@github-actions github-actions bot requested a review from BBBmau February 12, 2025 07:31
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from BBBmau February 16, 2025 18:37
Copy link

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Collaborator

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still seeing a lot of failures in GHA. please address them as it's preventing generation of the provider on this PR(i.e https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/13358205963/job/37303885197?pr=13049)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 671 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 5 files changed, 671 insertions(+), 15 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 152 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 22 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • memorystore

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

Copy link

github-actions bot commented Mar 3, 2025

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants