Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for updating persistent disk size and disk type in cloud workstations #12910

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

joelkattapuram
Copy link
Contributor

@joelkattapuram joelkattapuram commented Jan 29, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Add test for updating persistent disk size and disk type for cloud workstations configs.

@joelkattapuram joelkattapuram changed the title Add test to allow updating pd size and pd disk type Add test to allow updating persistent disk size and disk type Jan 29, 2025
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from hao-nan-li January 29, 2025 17:14
@joelkattapuram joelkattapuram changed the title Add test to allow updating persistent disk size and disk type Add test for updating persistent disk size and disk type in cloud workstations Jan 29, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 1 file changed, 79 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 38
Passed tests: 37
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • workstations

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkstationsWorkstationConfig_updatePersistentDirectory

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_updatePersistentDirectory [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 1 file changed, 122 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 38
Passed tests: 37
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • workstations

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkstationsWorkstationConfig_updatePersistentDirectory

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 1 file changed, 81 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 1 file changed, 81 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 38
Passed tests: 37
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • workstations

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkstationsWorkstationConfig_updatePersistentDirectory

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 38
Passed tests: 37
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • workstations

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkstationsWorkstationConfig_updatePersistentDirectory

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_updatePersistentDirectory [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_updatePersistentDirectory [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_updatePersistentDirectory [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can add the labels field into ImportStateVerifyIgnore

@github-actions github-actions bot requested a review from hao-nan-li February 1, 2025 00:15
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 1 file changed, 81 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 38
Passed tests: 37
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • workstations

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkstationsWorkstationConfig_updatePersistentDirectory

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_updatePersistentDirectory [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link

github-actions bot commented Feb 5, 2025

@hao-nan-li This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

github-actions bot commented Feb 7, 2025

@GoogleCloudPlatform/terraform-team @hao-nan-li This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 2 files changed, 81 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 38
Passed tests: 37
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • workstations

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkstationsWorkstationConfig_updatePersistentDirectory

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_updatePersistentDirectory [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 2 files changed, 84 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 38
Passed tests: 37
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • workstations

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkstationsWorkstationConfig_updatePersistentDirectory

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_updatePersistentDirectory [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants