-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DSF on resource_labels in node_config #12877
Add DSF on resource_labels in node_config #12877
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: 223 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Tests analyticsTotal tests: 223 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_container_cluster" "primary" {
node_config {
resource_labels = # value needed
}
node_pool {
node_config {
resource_labels = # value needed
}
}
}
|
Tests analyticsTotal tests: 223 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_container_cluster" "primary" {
node_config {
resource_labels = # value needed
}
node_pool {
node_config {
resource_labels = # value needed
}
}
}
|
Tests analyticsTotal tests: 223 Click here to see the affected service packages
🟢 All tests passed! View the build log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested this in all 3 locations node_config.resource_labels
appears?
Yes, manually tested by creating clusters/node pools and manually adding |
Fixes: hashicorp/terraform-provider-google#15848
Well, only adds a DSF on resource_labels, doesn't fix the inability to remove all resource_labels
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.