Add cloudbuild trigger InSpec resource #1274
Conversation
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 9baedb6) have been included in your existing downstream PRs. |
| @@ -593,7 +593,7 @@ def get_type(type) | |||
| def property_ns_prefix | |||
| [ | |||
| 'Google', | |||
| @__resource.__product.api_name.camelize(:upper), | |||
There was a problem hiding this comment.
I believe this was a bug in all providers that used this type system that was never surfaced because they didn't support Cloud Build.
Basically, it was turning "Cloud Build" to Cloudbuild rather than CloudBuild for module names on the ruby classes.
There was a problem hiding this comment.
Doesn't look like it affects anyone else, so I guess we're fine.
We should have a MM-wide conversation about what to do with these 'property_class' methods (which is what this is used for). It feels weird to have them in api/.
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit b354208) have been included in your existing downstream PRs. |
| @@ -593,7 +593,7 @@ def get_type(type) | |||
| def property_ns_prefix | |||
| [ | |||
| 'Google', | |||
| @__resource.__product.api_name.camelize(:upper), | |||
There was a problem hiding this comment.
Doesn't look like it affects anyone else, so I guess we're fine.
We should have a MM-wide conversation about what to do with these 'property_class' methods (which is what this is used for). It feels weird to have them in api/.
…n to escape markdown character *
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
inspec-cloud-build-trigger
branch
from
78127b4 to
5499923
Compare
Add InSpec support for CloudBuild trigger
[all]
[terraform]
[terraform-beta]
[ansible]
[inspec]