Add new resource netapp volumes quotaRules #12665

Mehul3217 · 2024-12-28T13:32:35Z

Release Note Template for Downstream PRs (will be copied)

`google_netapp_volume_quota_rule`

modular-magician · 2024-12-28T13:44:02Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1091 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1091 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 128 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_netapp_volume_quota_rule (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_volume_quota_rule" "primary" {
  description = # value needed
  labels      = # value needed
  target      = # value needed
}

modular-magician · 2024-12-28T13:46:25Z

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccNetappVolumeQuotaRule_netappVolumeQuotaRuleBasicExample
TestAccNetappVolumeQuotaRule_netappVolumeQuotaRuleBasicExample
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2024-12-28T19:52:04Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1176 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1176 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 116 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 130 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_netapp_volume_quota_rule (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_volume_quota_rule" "primary" {
  description = # value needed
  labels      = # value needed
  target      = # value needed
}

modular-magician · 2024-12-28T19:53:50Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1176 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1176 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 116 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 130 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_netapp_volume_quota_rule (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_volume_quota_rule" "primary" {
  description = # value needed
  labels      = # value needed
  target      = # value needed
}

modular-magician · 2024-12-28T20:40:59Z

Tests analytics

Total tests: 22
Passed tests: 20
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-12-28T20:42:14Z

🔴 Tests failed during RECORDING mode:
TestAccNetappVolumeQuotaRule_netappVolumeQuotaRuleBasicExample [Error message] [Debug log]
TestAccNetappVolumeQuotaRule_netappVolumeQuotaRuleBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-12-28T20:42:40Z

Tests analytics

Total tests: 22
Passed tests: 20
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-12-28T20:43:52Z

🔴 Tests failed during RECORDING mode:
TestAccNetappVolumeQuotaRule_netappVolumeQuotaRuleBasicExample [Error message] [Debug log]
TestAccNetappVolumeQuotaRule_netappVolumeQuotaRuleBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-12-28T21:10:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1176 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1176 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 116 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 130 insertions(+))

modular-magician · 2024-12-28T21:59:22Z

Tests analytics

Total tests: 22
Passed tests: 20
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-12-28T22:21:12Z

🔴 Tests failed during RECORDING mode:
TestAccNetappVolumeQuotaRule_netappVolumeQuotaRuleBasicExample [Error message] [Debug log]
TestAccNetappVolumeQuotaRule_netappVolumeQuotaRuleBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

okrause · 2025-01-20T10:36:11Z

mmv1/products/netapp/VolumeQuotaRule.yaml

+      - 'DEFAULT_USER_QUOTA'
+      - 'DEFAULT_GROUP_QUOTA'
+  - name: 'diskLimitMib'
+    type: String


Should this be type "Integer" so TF checks if it is a valid number?

okrause · 2025-01-20T10:38:17Z

mmv1/third_party/terraform/services/netapp/resource_netapp_volume_quotaRule_test.go

+  name = "testvolumequotaRule%{random_suffix}"
+  description = "This is a updated description"
+  type = "DEFAULT_USER_QUOTA"
+  disk_limit_mib = 50


Change the actual value too?

okrause · 2025-01-20T10:38:54Z

mmv1/third_party/terraform/services/netapp/resource_netapp_volume_quotaRule_test.go

+  protocols = ["NFSV3"]
+}
+
+resource "google_netapp_volume_quota_rule" "test_quotaRule" {


Can we add test for all 4 types of quotas?

modular-magician · 2025-01-22T09:28:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1262 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1262 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 116 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 130 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_netapp_volume_quota_rule (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_volume_quota_rule" "primary" {
  labels = # value needed
}

modular-magician · 2025-01-22T10:17:31Z

Tests analytics

Total tests: 22
Passed tests: 20
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-01-22T10:19:09Z

🔴 Tests failed during RECORDING mode:
TestAccNetappVolumeQuotaRule_netappVolumeQuotaRuleBasicExample [Error message] [Debug log]
TestAccNetappVolumeQuotaRule_netappVolumeQuotaRuleBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Mehul3217 · 2025-01-28T08:42:39Z

/gcbrun

github-actions · 2025-01-28T08:44:20Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

okrause

Thank you! Looks pretty good. Suggested a few small changes. I learned that it pay to be explicit in descriptions.

okrause · 2025-01-30T09:32:26Z

mmv1/products/netapp/VolumeQuotaRule.yaml

+name: 'VolumeQuotaRule'
+api_resource_type_kind: QuotaRule
+description: |
+ <TO BE FILLED>


QuotaRule specifies the maximum capacity a user or group can use within a volume. They can be used for creating default and individual quota rules.

okrause · 2025-01-30T09:33:21Z

mmv1/products/netapp/VolumeQuotaRule.yaml

+ <TO BE FILLED>
+references:
+  guides:
+    'Documentation': <TBD>


https://cloud.google.com/netapp/volumes/docs/configure-and-use/volumes/overview#volume_user_and_group_quotas

okrause · 2025-01-30T09:33:42Z

mmv1/products/netapp/VolumeQuotaRule.yaml

+references:
+  guides:
+    'Documentation': <TBD>
+  api: <TBD>


https://cloud.google.com/netapp/volumes/docs/reference/rest/v1/projects.locations.volumes.quotaRules

okrause · 2025-01-30T09:42:14Z

mmv1/products/netapp/VolumeQuotaRule.yaml

+  - name: 'target'
+    type: String
+    description: |
+      The quota rule applies to the specified user or group, identified by a Unix UID/GID, Windows SID, or null for default.


The quota rule applies to the specified user or group.
Valid targets for volumes with NFS protocol enabled:

UNIX UID for individual user quota

UNIX GID for individual group quota
Valid targets for volumes with SMB protocol enabled:

Windows SID for individual user quota

Leave empty for default quotas.

okrause · 2025-01-30T09:45:52Z

mmv1/products/netapp/VolumeQuotaRule.yaml

+  - name: 'diskLimitMib'
+    type: Integer
+    description:
+      The maximum allowed disk space in MiB.


"disk space" is a somehow outdated term. I would prefer to use "capacity" instead. Unfortunately, the term disk space is encoded in the field parameter. Now the question is: use "disk space" in parameter and description, or change description to "capacity"?

done, changed to capacity

github-actions · 2025-01-31T09:41:20Z

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

modular-magician · 2025-02-03T05:23:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1274 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1274 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 116 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 130 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_netapp_volume_quota_rule (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_volume_quota_rule" "primary" {
  labels = # value needed
}

modular-magician · 2025-02-03T06:18:04Z

Tests analytics

Total tests: 23
Passed tests: 21
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-02-03T06:21:12Z

🟢 Tests passed during RECORDING mode:
TestAccNetappVolumeQuotaRule_netappVolumeQuotaRuleBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccNetappVolumeQuotaRule_netappVolumeQuotaRuleBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-03T07:30:11Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1310 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1310 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 116 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 130 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_netapp_volume_quota_rule (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_volume_quota_rule" "primary" {
  labels = # value needed
}

modular-magician · 2025-02-03T08:24:20Z

Tests analytics

Total tests: 23
Passed tests: 22
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-02-03T08:28:36Z

🟢 Tests passed during RECORDING mode:
TestAccNetappVolumeQuotaRule_netappVolumeQuotaRuleBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

Mehul3217 · 2025-02-04T04:16:24Z

@BBBmau a gentle reminder to review this PR please

github-actions · 2025-02-04T09:41:36Z

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

melinath · 2025-02-04T17:58:38Z

@modular-magician reassign-reviewer

melinath · 2025-02-04T18:00:23Z

@SirGitsalot could you take a look at this today?

SirGitsalot

One small comment, otherwise LGTM

mmv1/products/netapp/VolumeQuotaRule.yaml

modular-magician · 2025-02-05T04:15:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1319 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1319 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 116 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 130 insertions(+))

modular-magician · 2025-02-05T05:09:58Z

Tests analytics

Total tests: 23
Passed tests: 22
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-02-05T05:14:14Z

🟢 Tests passed during RECORDING mode:
TestAccNetappVolumeQuotaRule_netappVolumeQuotaRuleBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

add new resource netapp volumes quotaRules

b7fe5be

modular-magician added the service/netapp label Dec 28, 2024

Mehul3217 added 2 commits December 28, 2024 19:40

add remaining fields and tests to netapp volumes quota rules resource

decf2e5

remove duplicate requried tag on quota rule yaml config

2d5fe66

update quota_rule_id parameter for create request

6fd7940

okrause reviewed Jan 20, 2025

View reviewed changes

add update tests for all quota types

34ee9fb

Mehul3217 marked this pull request as ready for review January 28, 2025 08:43

github-actions bot requested a review from BBBmau January 28, 2025 08:44

okrause suggested changes Jan 30, 2025

View reviewed changes

add descriptions and api docs for Quota Rules

491c934

correct quotaRule name for differnet resources

8646aa6

add resourceName for each type of quota rule

003227c

github-actions bot requested a review from SirGitsalot February 4, 2025 17:59

SirGitsalot requested changes Feb 4, 2025

View reviewed changes

mmv1/products/netapp/VolumeQuotaRule.yaml Outdated Show resolved Hide resolved

remove required:true from location in the API, add lables to tests

9222a31

github-actions bot requested a review from SirGitsalot February 5, 2025 04:05

melinath removed request for okrause and BBBmau February 6, 2025 16:56

SirGitsalot approved these changes Feb 6, 2025

View reviewed changes

SirGitsalot added this pull request to the merge queue Feb 6, 2025

Merged via the queue into GoogleCloudPlatform:main with commit 8bb1c80 Feb 6, 2025
23 checks passed

Dawid212 pushed a commit to Dawid212/magic-modules that referenced this pull request Feb 12, 2025

Add new resource netapp volumes quotaRules (GoogleCloudPlatform#12665)

2c058d2

Add new resource netapp volumes quotaRules #12665

Add new resource netapp volumes quotaRules #12665

Conversation

Mehul3217 commented Dec 28, 2024 • edited Loading

modular-magician commented Dec 28, 2024

Diff report

Missing test report

modular-magician commented Dec 28, 2024

Tests analytics

modular-magician commented Dec 28, 2024

Diff report

Missing test report

modular-magician commented Dec 28, 2024

Diff report

Missing test report

modular-magician commented Dec 28, 2024

Tests analytics

Action taken

modular-magician commented Dec 28, 2024

modular-magician commented Dec 28, 2024

Tests analytics

Action taken

modular-magician commented Dec 28, 2024

modular-magician commented Dec 28, 2024

Diff report

modular-magician commented Dec 28, 2024

Tests analytics

Action taken

modular-magician commented Dec 28, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

modular-magician commented Jan 22, 2025

Diff report

Missing test report

modular-magician commented Jan 22, 2025

Tests analytics

Action taken

modular-magician commented Jan 22, 2025

Mehul3217 commented Jan 28, 2025

github-actions bot commented Jan 28, 2025 • edited Loading

okrause left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jan 31, 2025

modular-magician commented Feb 3, 2025

Diff report

Missing test report

modular-magician commented Feb 3, 2025

Tests analytics

Action taken

modular-magician commented Feb 3, 2025

modular-magician commented Feb 3, 2025

Diff report

Missing test report

modular-magician commented Feb 3, 2025

Tests analytics

Action taken

modular-magician commented Feb 3, 2025

Mehul3217 commented Feb 4, 2025

github-actions bot commented Feb 4, 2025

melinath commented Feb 4, 2025

melinath commented Feb 4, 2025

SirGitsalot left a comment

Choose a reason for hiding this comment

modular-magician commented Feb 5, 2025

Diff report

modular-magician commented Feb 5, 2025

Mehul3217 commented Dec 28, 2024 •

edited

Loading

github-actions bot commented Jan 28, 2025 •

edited

Loading