-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add edgenetwork Router resource. #12594
base: main
Are you sure you want to change the base?
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly needs more testing (unless the resource is immutable), but otherwise LGTM
mmv1/templates/terraform/examples/edgenetwork_router_minimal.tf.tmpl
Outdated
Show resolved
Hide resolved
@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@f1urps understood, but we would still need to see working test output (for the other examples), before we can submit. Is there a person who this is passing to? Otherwise I would expect this will become stale unfortunately. Leaving a comment on b/298278262 as well.
@f1urps, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. This notification can be disabled with the |
@f1urps, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. This notification can be disabled with the |
Create Router resource in product edgenetwork.
Fixes hashicorp/terraform-provider-google#15666
Tests are disabled for this resource for the same reason as other resources in
edgenetwork
. See: #8905This PR depends on another in-review PR: #12586
Release Note Template for Downstream PRs (will be copied)