Add Repository Group resource with IAM #12424

JumiDeluxe · 2024-11-25T13:26:30Z

Release Note Template for Downstream PRs (will be copied)

Add new resources for Gemini Code Assist

`google_gemini_repository_group` (beta only)

`google_gemini_repository_group_iam_member` (beta only)

`google_gemini_repository_group_iam_binding` (beta only)

`google_gemini_repository_group_iam_policy` (beta only)

github-actions · 2024-11-25T13:27:11Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2024-11-25T13:37:31Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 537 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 22 files changed, 3099 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

JumiDeluxe · 2024-11-25T13:42:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 537 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 22 files changed, 3099 insertions(+), 5 deletions(-)) terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests) Please add an acceptance test which includes these fields. The test should include the following:
resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}
Resource: google_gemini_repository_group_iam_member (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:
resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Just a reminder that this resource will not support conditions at this moment

modular-magician · 2024-11-25T13:42:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 537 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 22 files changed, 3099 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-25T14:50:25Z

Tests analytics

Total tests: 4320
Passed tests: 3906
Skipped tests: 407
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeDeveloper_apigeeDeveloperUpdateTest

TestAccGeminiCodeRepositoryIndex_update

TestAccGeminiRepositoryGroupIamBinding

TestAccGeminiRepositoryGroupIamMember

TestAccGeminiRepositoryGroupIamPolicy

TestAccGeminiRepositoryGroup_update

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-25T14:55:36Z

Tests analytics

Total tests: 4320
Passed tests: 3906
Skipped tests: 407
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeDeveloper_apigeeDeveloperUpdateTest

TestAccGeminiCodeRepositoryIndex_update

TestAccGeminiRepositoryGroupIamBinding

TestAccGeminiRepositoryGroupIamMember

TestAccGeminiRepositoryGroupIamPolicy

TestAccGeminiRepositoryGroup_update

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-25T14:58:14Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 537 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 22 files changed, 3094 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-25T15:10:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 537 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 22 files changed, 3094 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-25T15:48:16Z

🟢 Tests passed during RECORDING mode:
TestAccGeminiCodeRepositoryIndex_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBinding [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMember [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicy [Error message] [Debug log]
TestAccGeminiRepositoryGroup_update [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-25T16:11:58Z

Tests analytics

Total tests: 4320
Passed tests: 3906
Skipped tests: 407
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeDeveloper_apigeeDeveloperUpdateTest

TestAccGeminiCodeRepositoryIndex_update

TestAccGeminiRepositoryGroupIamBinding

TestAccGeminiRepositoryGroupIamMember

TestAccGeminiRepositoryGroupIamPolicy

TestAccGeminiRepositoryGroup_update

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-25T16:20:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 537 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 22 files changed, 3092 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-25T16:24:04Z

Tests analytics

Total tests: 4320
Passed tests: 3906
Skipped tests: 407
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeDeveloper_apigeeDeveloperUpdateTest

TestAccGeminiCodeRepositoryIndex_update

TestAccGeminiRepositoryGroupIamBinding

TestAccGeminiRepositoryGroupIamMember

TestAccGeminiRepositoryGroupIamPolicy

TestAccGeminiRepositoryGroup_update

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-25T17:04:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 537 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 22 files changed, 3163 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-25T17:08:08Z

🟢 Tests passed during RECORDING mode:
TestAccGeminiCodeRepositoryIndex_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBinding [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMember [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicy [Error message] [Debug log]
TestAccGeminiRepositoryGroup_update [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-25T17:23:04Z

🟢 Tests passed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Debug log]
TestAccGeminiRepositoryGroupIamMember [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccGeminiCodeRepositoryIndex_update [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBinding [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicy [Error message] [Debug log]
TestAccGeminiRepositoryGroup_update [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-25T17:33:42Z

Tests analytics

Total tests: 4320
Passed tests: 3908
Skipped tests: 407
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGeminiRepositoryGroupIamBinding

TestAccGeminiRepositoryGroupIamMember

TestAccGeminiRepositoryGroupIamPolicy

TestAccGeminiRepositoryGroup_update

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-25T18:16:56Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 537 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 22 files changed, 3226 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-25T18:18:59Z

Tests analytics

Total tests: 4322
Passed tests: 3908
Skipped tests: 407
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeDeveloper_apigeeDeveloperUpdateTest

TestAccGeminiRepositoryGroupIamBinding

TestAccGeminiRepositoryGroupIamMember

TestAccGeminiRepositoryGroupIamPolicy

TestAccGeminiRepositoryGroup_noBootstrao

TestAccGeminiRepositoryGroup_update

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-25T18:30:05Z

🟢 Tests passed during RECORDING mode:
TestAccGeminiRepositoryGroupIamMember [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccGeminiRepositoryGroupIamBinding [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicy [Error message] [Debug log]
TestAccGeminiRepositoryGroup_update [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-25T18:59:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 537 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 22 files changed, 3226 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-25T19:18:01Z

🟢 Tests passed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Debug log]
TestAccGeminiRepositoryGroupIamMember [Debug log]
TestAccGeminiRepositoryGroup_noBootstrao [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccGeminiRepositoryGroupIamBinding [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicy [Error message] [Debug log]
TestAccGeminiRepositoryGroup_update [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-25T19:29:43Z

Tests analytics

Total tests: 4322
Passed tests: 3909
Skipped tests: 407
Affected tests: 6

Click here to see the affected service packages

All service packages are affected

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGeminiRepositoryGroupIamBinding

TestAccGeminiRepositoryGroupIamMember

TestAccGeminiRepositoryGroupIamPolicy

TestAccGeminiRepositoryGroup_noBootstrao

TestAccGeminiRepositoryGroup_update

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-25T19:32:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 537 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 22 files changed, 3226 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

mmv1/third_party/terraform/services/gemini/resource_gemini_repository_group_test.go.tmpl

modular-magician · 2024-11-25T20:11:39Z

Tests analytics

Total tests: 4322
Passed tests: 3907
Skipped tests: 407
Affected tests: 8

Click here to see the affected service packages

All service packages are affected

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

TestAccFolderIamPolicy_basic

TestAccGeminiRepositoryGroupIamBinding

TestAccGeminiRepositoryGroupIamMember

TestAccGeminiRepositoryGroupIamPolicy

TestAccGeminiRepositoryGroup_noBootstrao

TestAccGeminiRepositoryGroup_update

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-27T14:41:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 409 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 15 files changed, 2440 insertions(+), 39 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 510 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-27T15:53:48Z

Tests analytics

Total tests: 4328
Passed tests: 3909
Skipped tests: 407
Affected tests: 12

Click here to see the affected service packages

All service packages are affected

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGeminiRepositoryGroupIamBindingGenerated

TestAccGeminiRepositoryGroupIamMemberGenerated

TestAccGeminiRepositoryGroupIamPolicyGenerated

TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample

TestAccOracleDatabaseAutonomousDatabase_basic

TestAccOracleDatabaseAutonomousDatabases_basic

TestAccOracleDatabaseCloudExadataInfrastructure_basic

TestAccOracleDatabaseCloudExadataInfrastructures_basic

TestAccOracleDatabaseCloudVmCluster_basic

TestAccOracleDatabaseDbNodes_basic

TestAccOracleDatabaseDbServers_basic

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-27T16:56:19Z

🟢 Tests passed during RECORDING mode:
TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccGeminiRepositoryGroupIamBindingGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated [Error message] [Debug log]
TestAccOracleDatabaseAutonomousDatabase_basic [Error message] [Debug log]
TestAccOracleDatabaseAutonomousDatabases_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructure_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructures_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudVmCluster_basic [Error message] [Debug log]
TestAccOracleDatabaseDbNodes_basic [Error message] [Debug log]
TestAccOracleDatabaseDbServers_basic [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-27T17:09:20Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 409 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 15 files changed, 2440 insertions(+), 39 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 510 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-27T18:22:10Z

Tests analytics

Total tests: 4328
Passed tests: 3910
Skipped tests: 407
Affected tests: 11

Click here to see the affected service packages

All service packages are affected

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGeminiRepositoryGroupIamBindingGenerated

TestAccGeminiRepositoryGroupIamMemberGenerated

TestAccGeminiRepositoryGroupIamPolicyGenerated

TestAccOracleDatabaseAutonomousDatabase_basic

TestAccOracleDatabaseAutonomousDatabases_basic

TestAccOracleDatabaseCloudExadataInfrastructure_basic

TestAccOracleDatabaseCloudExadataInfrastructures_basic

TestAccOracleDatabaseCloudVmCluster_basic

TestAccOracleDatabaseDbNodes_basic

TestAccOracleDatabaseDbServers_basic

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-27T19:25:29Z

🟢 Tests passed during RECORDING mode:
TestAccGeminiRepositoryGroupIamPolicyGenerated [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccGeminiRepositoryGroupIamBindingGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated [Error message] [Debug log]
TestAccOracleDatabaseAutonomousDatabase_basic [Error message] [Debug log]
TestAccOracleDatabaseAutonomousDatabases_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructure_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructures_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudVmCluster_basic [Error message] [Debug log]
TestAccOracleDatabaseDbNodes_basic [Error message] [Debug log]
TestAccOracleDatabaseDbServers_basic [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-27T20:47:51Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 409 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 15 files changed, 2440 insertions(+), 39 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 510 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-27T22:00:36Z

Tests analytics

Total tests: 4330
Passed tests: 3911
Skipped tests: 407
Affected tests: 12

Click here to see the affected service packages

All service packages are affected

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeDeveloper_apigeeDeveloperUpdateTest

TestAccApigeeEnvironmentKeyvaluemaps_apigeeEnvironmentKeyvaluemapsBetaTestExample

TestAccGeminiRepositoryGroupIamBindingGenerated

TestAccGeminiRepositoryGroupIamMemberGenerated

TestAccOracleDatabaseAutonomousDatabase_basic

TestAccOracleDatabaseAutonomousDatabases_basic

TestAccOracleDatabaseCloudExadataInfrastructure_basic

TestAccOracleDatabaseCloudExadataInfrastructures_basic

TestAccOracleDatabaseCloudVmCluster_basic

TestAccOracleDatabaseDbNodes_basic

TestAccOracleDatabaseDbServers_basic

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-27T23:02:34Z

🟢 Tests passed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Debug log]
TestAccApigeeEnvironmentKeyvaluemaps_apigeeEnvironmentKeyvaluemapsBetaTestExample [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccGeminiRepositoryGroupIamBindingGenerated [Error message] [Debug log]
TestAccOracleDatabaseAutonomousDatabase_basic [Error message] [Debug log]
TestAccOracleDatabaseAutonomousDatabases_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructure_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructures_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudVmCluster_basic [Error message] [Debug log]
TestAccOracleDatabaseDbNodes_basic [Error message] [Debug log]
TestAccOracleDatabaseDbServers_basic [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-28T13:07:56Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 407 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 14 files changed, 2321 insertions(+), 39 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 510 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  code_repository_index = # value needed
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  code_repository_index = # value needed
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_policy (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_policy" "primary" {
  code_repository_index = # value needed
}

modular-magician · 2024-11-28T14:19:57Z

Tests analytics

Total tests: 4329
Passed tests: 3911
Skipped tests: 407
Affected tests: 11

Click here to see the affected service packages

All service packages are affected

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGeminiRepositoryGroupIamBinding

TestAccGeminiRepositoryGroupIamMember

TestAccGeminiRepositoryGroupIamPolicy

TestAccOracleDatabaseAutonomousDatabase_basic

TestAccOracleDatabaseAutonomousDatabases_basic

TestAccOracleDatabaseCloudExadataInfrastructure_basic

TestAccOracleDatabaseCloudExadataInfrastructures_basic

TestAccOracleDatabaseCloudVmCluster_basic

TestAccOracleDatabaseDbNodes_basic

TestAccOracleDatabaseDbServers_basic

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-28T15:17:11Z

🔴 Tests failed during RECORDING mode:
TestAccGeminiRepositoryGroupIamBinding [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMember [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicy [Error message] [Debug log]
TestAccOracleDatabaseAutonomousDatabase_basic [Error message] [Debug log]
TestAccOracleDatabaseAutonomousDatabases_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructure_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructures_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudVmCluster_basic [Error message] [Debug log]
TestAccOracleDatabaseDbNodes_basic [Error message] [Debug log]
TestAccOracleDatabaseDbServers_basic [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-28T16:12:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 407 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 14 files changed, 2321 insertions(+), 39 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 510 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-28T17:33:23Z

Tests analytics

Total tests: 4329
Passed tests: 3914
Skipped tests: 407
Affected tests: 8

Click here to see the affected service packages

All service packages are affected

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccOracleDatabaseAutonomousDatabase_basic

TestAccOracleDatabaseAutonomousDatabases_basic

TestAccOracleDatabaseCloudExadataInfrastructure_basic

TestAccOracleDatabaseCloudExadataInfrastructures_basic

TestAccOracleDatabaseCloudVmCluster_basic

TestAccOracleDatabaseDbNodes_basic

TestAccOracleDatabaseDbServers_basic

TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

modular-magician · 2024-11-28T18:28:28Z

🔴 Tests failed during RECORDING mode:
TestAccOracleDatabaseAutonomousDatabase_basic [Error message] [Debug log]
TestAccOracleDatabaseAutonomousDatabases_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructure_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructures_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudVmCluster_basic [Error message] [Debug log]
TestAccOracleDatabaseDbNodes_basic [Error message] [Debug log]
TestAccOracleDatabaseDbServers_basic [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

github-actions · 2024-11-29T09:42:13Z

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2024-12-03T09:42:23Z

@GoogleCloudPlatform/terraform-team @slevenick This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

JumiDeluxe marked this pull request as draft November 25, 2024 13:26

github-actions bot requested a review from slevenick November 25, 2024 13:27

JumiDeluxe marked this pull request as ready for review November 25, 2024 16:22

JumiDeluxe force-pushed the repository-group branch from 21a0e1f to 8cdc5b6 Compare November 25, 2024 18:48

JumiDeluxe force-pushed the repository-group branch from 8cdc5b6 to 51740e8 Compare November 25, 2024 19:21

slevenick reviewed Nov 25, 2024

View reviewed changes

mmv1/third_party/terraform/services/gemini/resource_gemini_repository_group_test.go.tmpl Outdated Show resolved Hide resolved

mmv1/third_party/terraform/services/gemini/resource_gemini_repository_group_test.go.tmpl Show resolved Hide resolved

JumiDeluxe force-pushed the repository-group branch from c9fae0b to 91bb8d1 Compare November 27, 2024 14:31

JumiDeluxe force-pushed the repository-group branch from 91bb8d1 to 33dbad6 Compare November 27, 2024 16:58

JumiDeluxe force-pushed the repository-group branch from 33dbad6 to 34c677c Compare November 27, 2024 20:36

JumiDeluxe force-pushed the repository-group branch from 34c677c to abb4e74 Compare November 28, 2024 12:57

Remove not needed beta tags

3e09a08

JumiDeluxe force-pushed the repository-group branch from abb4e74 to 3e09a08 Compare November 28, 2024 15:58

slevenick approved these changes Dec 3, 2024

View reviewed changes

slevenick merged commit a323c5a into GoogleCloudPlatform:main Dec 3, 2024
16 of 18 checks passed

This was referenced Dec 3, 2024

Add Repository Group resource with IAM hashicorp/terraform-provider-google#20557

Merged

Add Repository Group resource with IAM hashicorp/terraform-provider-google-beta#8824

Merged

JumiDeluxe mentioned this pull request Dec 3, 2024

Add Gemini Code Assist for Google Cloud resources #12181

Closed

modular-magician mentioned this pull request Dec 3, 2024

Add Repository Group resource with IAM GoogleCloudPlatform/terraform-google-conversion#3157

Merged

amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024

Add Repository Group resource with IAM (GoogleCloudPlatform#12424)

2862618

Add Repository Group resource with IAM #12424

Add Repository Group resource with IAM #12424

Conversation

JumiDeluxe commented Nov 25, 2024 • edited by slevenick Loading

github-actions bot commented Nov 25, 2024

modular-magician commented Nov 25, 2024

Diff report

Missing test report

JumiDeluxe commented Nov 25, 2024

Diff report

Missing test report

modular-magician commented Nov 25, 2024

Diff report

Missing test report

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 25, 2024

Diff report

Missing test report

modular-magician commented Nov 25, 2024

Diff report

Missing test report

modular-magician commented Nov 25, 2024

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 25, 2024

Diff report

Missing test report

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 25, 2024

Diff report

Missing test report

modular-magician commented Nov 25, 2024

modular-magician commented Nov 25, 2024

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 25, 2024

Diff report

Missing test report

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 25, 2024

modular-magician commented Nov 25, 2024

Diff report

Missing test report

modular-magician commented Nov 25, 2024

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 25, 2024

Diff report

Missing test report

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 27, 2024

Diff report

Missing test report

modular-magician commented Nov 27, 2024

Tests analytics

Action taken

modular-magician commented Nov 27, 2024

modular-magician commented Nov 27, 2024

Diff report

Missing test report

modular-magician commented Nov 27, 2024

Tests analytics

Action taken

modular-magician commented Nov 27, 2024

modular-magician commented Nov 27, 2024

Diff report

JumiDeluxe commented Nov 25, 2024 •

edited by slevenick

Loading