Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CA_ENTERPRISE_ANNUAL option for ProjectCloudArmorTier; #12352

Conversation

matheusaleixo-cit
Copy link
Contributor

@matheusaleixo-cit matheusaleixo-cit commented Nov 18, 2024

Adds the capability to enroll a project to CA_ENTERPRISE_ANNUAL when using the ProjectCloudArmorTier resource.

Fixes: hashicorp/terraform-provider-google#19703

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `CA_ENTERPRISE_ANNUAL` option for field `cloud_armor_tier` in `google_compute_project_cloud_armor_tier` resource

@matheusaleixo-cit matheusaleixo-cit marked this pull request as ready for review November 18, 2024 22:54
@github-actions github-actions bot requested a review from NickElliot November 18, 2024 22:55
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Copy link

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 162 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 162 insertions(+), 3 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 104 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1066
Passed tests: 991
Skipped tests: 75
Affected tests: 0

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccComputeProjectCloudArmorTier_computeProjectCloudArmorTierBasicExample
  • TestAccComputeProjectCloudArmorTier_computeProjectCloudArmorTierProjectSetExample
    🟢 All tests passed!

View the build log

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, just wanted to check one thing: was there a reason you bumped those tests from skipping generation? otherwise LGTM

@matheusaleixo-cit
Copy link
Contributor Author

matheusaleixo-cit commented Nov 26, 2024

Hi, just wanted to check one thing: was there a reason you bumped those tests from skipping generation? otherwise LGTM

I just made these changes so I could edit and run these tests locally (I wanted to confirm the API availability for CA_ENTERPRISE_ANNUAL), but I'm ok with reverting those if necessary.

@github-actions github-actions bot requested a review from NickElliot November 26, 2024 14:56
Copy link

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you could go ahead and change them back please then, thanks!

@github-actions github-actions bot requested a review from NickElliot December 2, 2024 22:34
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 2, 2024
Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NickElliot NickElliot merged commit 60ec71e into GoogleCloudPlatform:main Dec 5, 2024
7 of 8 checks passed
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
@matheusaleixo-cit matheusaleixo-cit deleted the add-ca-enterprise-annual-option-for-project-cloud-armor-tier branch December 20, 2024 18:40
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/compute-security-policy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CA_ENTERPRISE_ANNUAL to google_compute_project_cloud_armor_tier
3 participants