Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clean-provider target in GNUmakefile to not remove TPG/TPGB CODEOWNERS files #12274

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

SarahFrench
Copy link
Contributor

@SarahFrench SarahFrench commented Nov 7, 2024

Unblocks hashicorp/terraform-provider-google#20227
Unblocks hashicorp/terraform-provider-google-beta#8650

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@SarahFrench SarahFrench changed the title Update clean-provider target in GNUmakefile to not remove TPG/TPGB … Update clean-provider target in GNUmakefile to not remove TPG/TPGB CODEOWNERS files Nov 7, 2024
@SarahFrench SarahFrench marked this pull request as ready for review November 7, 2024 19:48
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@SarahFrench
Copy link
Contributor Author

Checks are being weird and I cannot find linked builds - re-running: /gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Copy link

This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@SarahFrench SarahFrench requested a review from melinath November 14, 2024 18:02
@SarahFrench SarahFrench merged commit 6632560 into main Nov 14, 2024
14 checks passed
bradhoekstra pushed a commit to bradhoekstra/magic-modules that referenced this pull request Nov 15, 2024
zeleena pushed a commit to zeleena/magic-modules that referenced this pull request Nov 18, 2024
@SarahFrench SarahFrench deleted the SarahFrench-patch-1 branch November 22, 2024 19:04
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants