Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test arguments for oracledatabase_cloudexadatainfrastructure #11991

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

tulika-aakriti
Copy link
Contributor

@tulika-aakriti tulika-aakriti commented Oct 14, 2024

Part of: hashicorp/terraform-provider-google#19701

we create fake resources for tests i.e prefix ofake for ids. Remove that from documentation and override it later for tests.

Release Note Template for Downstream PRs (will be copied)

`google_oracle_database_cloud_exadata_infrastructure`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from ScottSuarez October 14, 2024 10:40
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 14 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 2 files changed, 14 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3
Passed tests: 1
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • oracledatabase

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadataInfrastructureBasicExample
  • TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadataInfrastructureFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadataInfrastructureBasicExample[Debug log]
TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadataInfrastructureFullExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@ScottSuarez ScottSuarez merged commit c1921b7 into GoogleCloudPlatform:main Oct 14, 2024
13 of 14 checks passed
@tulika-aakriti tulika-aakriti deleted the exadata branch October 14, 2024 18:08
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants