-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send empty GKE objects explicitly #11978
Merged
rileykarson
merged 1 commit into
GoogleCloudPlatform:main
from
rileykarson:gke-sendempty
Oct 14, 2024
Merged
Send empty GKE objects explicitly #11978
rileykarson
merged 1 commit into
GoogleCloudPlatform:main
from
rileykarson:gke-sendempty
Oct 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests analyticsTotal tests: 212 Click here to see the affected service packages
🟢 All tests passed! View the build log |
slevenick
approved these changes
Oct 14, 2024
gontech
pushed a commit
to gontech/magic-modules
that referenced
this pull request
Oct 16, 2024
BBBmau
pushed a commit
to BBBmau/magic-modules
that referenced
this pull request
Oct 23, 2024
BBBmau
pushed a commit
to BBBmau/magic-modules
that referenced
this pull request
Oct 24, 2024
BBBmau
pushed a commit
to BBBmau/magic-modules
that referenced
this pull request
Nov 5, 2024
akshat-jindal-nit
pushed a commit
to akshat-jindal-nit/magic-modules
that referenced
this pull request
Nov 18, 2024
amanMahendroo
pushed a commit
to amanMahendroo/magic-modules
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is mainly just to correct some currently misleading code- 2/3 of these fields are Computed and can't actually trigger this check (at least in reasonable circumstances) and
linux_node_config
still has a permadiff afterwards. This does mean that updates that removelinux_node_config
that also include other changes will move on to the other changes so it at least has some user benefit, in addition to stopping the misleading snippet from propagating. This could be valid for some blocks, just not the one where is still happens!Followup to #11971
Release Note Template for Downstream PRs (will be copied)