Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send empty GKE objects explicitly #11978

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

rileykarson
Copy link
Member

This change is mainly just to correct some currently misleading code- 2/3 of these fields are Computed and can't actually trigger this check (at least in reasonable circumstances) and linux_node_config still has a permadiff afterwards. This does mean that updates that remove linux_node_config that also include other changes will move on to the other changes so it at least has some user benefit, in addition to stopping the misleading snippet from propagating. This could be valid for some blocks, just not the one where is still happens!

Followup to #11971

Release Note Template for Downstream PRs (will be copied)

container: `node_config.linux_config`, `node_config.workload_metadata_config` and `node_config.kubelet_config` will now successfully send empty messages to the API when `terraform plan` indicates they are being removed, rather than null, which caused an error. The sole reliable case is `node_config.linux_config` when the block is removed, where there will still be a permadiff, but the update request that's triggered will no longer error and other changes displayed in the plan should go through.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+))
google-beta provider: Diff ( 1 file changed, 3 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 212
Passed tests: 199
Skipped tests: 13
Affected tests: 0

Click here to see the affected service packages
  • container

🟢 All tests passed!

View the build log

@rileykarson rileykarson merged commit 285e7be into GoogleCloudPlatform:main Oct 14, 2024
11 checks passed
@rileykarson rileykarson deleted the gke-sendempty branch October 14, 2024 19:58
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants