Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break best practices pages out into standalone pages #11962

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

rileykarson
Copy link
Member

Mainly for discovery, as this puts the titles of the sections in the sidebar.

Release Note Template for Downstream PRs (will be copied)

@rileykarson rileykarson requested a review from melinath October 9, 2024 19:49
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this has been bugging me for a while, thanks!

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@rileykarson rileykarson merged commit 54e6e59 into GoogleCloudPlatform:main Oct 9, 2024
11 checks passed
@rileykarson rileykarson deleted the docs-bp branch October 9, 2024 21:55
trodge pushed a commit to trodge/magic-modules that referenced this pull request Oct 10, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 10, 2024
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants