Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing test for data.google_firebase_web_app_config, clean up plugin-framework Firebase code a bit #11927

Conversation

SarahFrench
Copy link
Contributor

@SarahFrench SarahFrench commented Oct 4, 2024

This PR:

  • adds a missing test for the Firebase data sources in the provider
  • slightly refactors existing Firebases data sources that have been migrated to the plugin-framework
    • doesn't impact function, instead structures the code differently and adds new comments

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+))
google-beta provider: Diff ( 4 files changed, 77 insertions(+), 21 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 14
Skipped tests: 4
Affected tests: 0

Click here to see the affected service packages
  • firebase

🟢 All tests passed!

View the build log

@SarahFrench
Copy link
Contributor Author

SarahFrench commented Oct 7, 2024

Here's a TeamCity build running all Firebase acc tests on this PR's changes: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_BETA_MMUPSTREAMTESTS_GOOGLEBETA_PACKAGE_FIREBASE/245968?hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildChangesSection=true

Edit: all tests passed, including the new TestAccDataSourceGoogleFirebaseWebAppConfig

@SarahFrench SarahFrench marked this pull request as ready for review October 7, 2024 13:38
@SarahFrench SarahFrench requested a review from trodge October 7, 2024 13:39
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+))
google-beta provider: Diff ( 4 files changed, 78 insertions(+), 21 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 13
Skipped tests: 5
Affected tests: 0

Click here to see the affected service packages
  • firebase
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccDataSourceGoogleFirebaseWebAppConfig
    🟢 All tests passed!

View the build log

@SarahFrench
Copy link
Contributor Author

Thanks!

@SarahFrench SarahFrench merged commit 8ab5c95 into GoogleCloudPlatform:main Oct 9, 2024
11 checks passed
trodge pushed a commit to trodge/magic-modules that referenced this pull request Oct 10, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 10, 2024
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants