Allow sending false for enabled field under IAP message for resource google_compute_backend_service and resource google_compute_region_backend_service

[arnabadg-google]

fixes hashicorp/terraform-provider-google#19596

Release Note Template for Downstream PRs (will be copied)

compute: fixed an issue in `google_compute_backend_service` and `google_compute_region_backend_service` to allow sending `false` for `iap.enabled`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

[slevenick]

Can you add a test that uses this? It would show up if you have a test where you set enabled = true and then have another step that sets enabled = false. Switching from true --> false forces sending the false value for everything to pass

[modular-magician]

Tests analytics

Total tests: 1026
Passed tests: 952
Skipped tests: 74
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[arnabadg-google]

Can you add a test that uses this? It would show up if you have a test where you set enabled = true and then have another step that sets enabled = false. Switching from true --> false forces sending the false value for everything to pass

Added update test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 138 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 138 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 140 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 140 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1028
Passed tests: 952
Skipped tests: 74
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeBackendService_updateIAPEnabled
• TestAccComputeRegionBackendService_updateIAPEnabled

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeBackendService_updateIAPEnabled[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionBackendService_updateIAPEnabled[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 1028
Passed tests: 952
Skipped tests: 74
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeBackendService_updateIAPEnabled
• TestAccComputeRegionBackendService_updateIAPEnabled

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeBackendService_updateIAPEnabled[Debug log]
TestAccComputeRegionBackendService_updateIAPEnabled[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test