-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming all remaining skip_* attributes #11696
Renaming all remaining skip_* attributes #11696
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
description: | ||
"Output only. Current step of the installation process. \n Possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line needs to be edited to not have values:
be the first term in the line: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/products/developerconnect/Connection.yaml#L143C21-L143C110
then I think this can be regenerated
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_developer_connect_connection" "primary" {
annotations = # value needed
etag = # value needed
installation_state {
action_uri = # value needed
message = # value needed
}
labels = # value needed
}
|
Tests analyticsTotal tests: 18 Click here to see the affected service packages
View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_developer_connect_connection" "primary" {
annotations = # value needed
etag = # value needed
installation_state {
action_uri = # value needed
message = # value needed
}
labels = # value needed
}
|
Tests analyticsTotal tests: 3 Click here to see the affected service packages
View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
all attributes except
skip_vcr
renamed. There are a few in tpgtools override files, but tpgtools isnt being touched in go rewrite so it doesn't seem like it needs to happen with this batchRelease Note Template for Downstream PRs (will be copied)