Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming all remaining skip_* attributes #11696

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

NickElliot
Copy link
Contributor

@NickElliot NickElliot commented Sep 12, 2024

all attributes except skip_vcr renamed. There are a few in tpgtools override files, but tpgtools isnt being touched in go rewrite so it doesn't seem like it needs to happen with this batch

Release Note Template for Downstream PRs (will be copied)


@NickElliot NickElliot requested a review from c2thorn September 12, 2024 20:23
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Comment on lines 155 to 156
description:
"Output only. Current step of the installation process. \n Possible
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line needs to be edited to not have values: be the first term in the line: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/products/developerconnect/Connection.yaml#L143C21-L143C110

then I think this can be regenerated

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 39 insertions(+), 38 deletions(-))
google-beta provider: Diff ( 2 files changed, 83 insertions(+), 81 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  annotations = # value needed
  etag        = # value needed
  installation_state {
    action_uri = # value needed
    message    = # value needed
  }
  labels = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 18
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • developerconnect
  • securitycenter

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 40 insertions(+), 39 deletions(-))
google-beta provider: Diff ( 2 files changed, 85 insertions(+), 83 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  annotations = # value needed
  etag        = # value needed
  installation_state {
    action_uri = # value needed
    message    = # value needed
  }
  labels = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3
Passed tests: 3
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • developerconnect

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@NickElliot NickElliot merged commit 1cee8f6 into GoogleCloudPlatform:main Sep 16, 2024
7 checks passed
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

abd-goog pushed a commit to abd-goog/magic-modules that referenced this pull request Sep 23, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
Philip-Jonany pushed a commit to Philip-Jonany/magic-modules that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants