Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed name of SCC v2 org bigquery export resource #11661

Merged

Conversation

melinath
Copy link
Member

@melinath melinath commented Sep 6, 2024

This is a follow-up to #11657 to add a version of the resource with the correct name and deprecate the resource with the incorrect name.

Release Note Template for Downstream PRs (will be copied)

securitycenterv2: deprecated `google_scc_v2_organization_scc_big_query_exports`. Use `google_scc_v2_organization_scc_big_query_export` instead.

@melinath melinath requested a review from c2thorn September 6, 2024 22:03
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 835 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 6 files changed, 835 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 99 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_v2_organization_scc_big_query_export (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_organization_scc_big_query_export" "primary" {
  big_query_export_id = # value needed
  dataset             = # value needed
  description         = # value needed
  filter              = # value needed
  location            = # value needed
  name                = # value needed
  organization        = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 16
Passed tests: 16
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • securitycenterv2

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 980 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 8 files changed, 980 insertions(+), 9 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 99 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 17
Passed tests: 16
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • securitycenterv2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityCenterV2OrganizationBigQueryExportsConfig_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSecurityCenterV2OrganizationBigQueryExportsConfig_basic[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

Copy link

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants