Add support for GPU fields in Cloud Run Service v1 and v2 api #11597

trshafer · 2024-08-30T21:23:08Z

Adds support for GPU fields which requires changes to limits as well as adding a new field nodeSelector to v1 and v2 api.

Release Note Template for Downstream PRs (will be copied)

cloudrun: added `nvidia.com/gpu` to `resources` and `node_selector` to  `google_cloud_run_service` resource (beta)

cloudrunv2: added `nvidia.com/gpu` to `resources` and `node_selector` to `google_cloud_run_v2_service` resource (beta)

modular-magician · 2024-08-30T21:35:25Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 119 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 258 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 48 insertions(+))

modular-magician · 2024-08-30T21:40:54Z

Tests analytics

Total tests: 74
Passed tests: 61
Skipped tests: 12
Affected tests: 1

Click here to see the affected service packages

cloudrun

cloudrunv2

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccCloudRunService_resourcesRequirements

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudRunV2Service_cloudrunv2ServiceWithResourcesRequirements

Get to know how VCR tests work

modular-magician · 2024-08-30T21:41:08Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudRunV2Service_cloudrunv2ServiceWithResourcesRequirements[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician · 2024-08-30T22:11:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 19 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 243 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 48 insertions(+))

github-actions · 2024-08-30T22:16:46Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2024-08-30T22:16:56Z

Tests analytics

Total tests: 74
Passed tests: 61
Skipped tests: 12
Affected tests: 1

Click here to see the affected service packages

cloudrun

cloudrunv2

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccCloudRunService_resourcesRequirements

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudRunV2Service_cloudrunv2ServiceWithResourcesRequirements

Get to know how VCR tests work

modular-magician · 2024-08-30T22:17:11Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudRunV2Service_cloudrunv2ServiceWithResourcesRequirements[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician · 2024-09-03T16:34:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 19 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 243 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 48 insertions(+))

modular-magician · 2024-09-03T16:39:59Z

Tests analytics

Total tests: 74
Passed tests: 61
Skipped tests: 12
Affected tests: 1

Click here to see the affected service packages

cloudrunv2

cloudrun

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccCloudRunService_resourcesRequirements

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudRunV2Service_cloudrunv2ServiceWithResourcesRequirements

Get to know how VCR tests work

modular-magician · 2024-09-03T16:55:53Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudRunV2Service_cloudrunv2ServiceWithResourcesRequirements[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician · 2024-09-03T18:32:12Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 19 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 243 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 48 insertions(+))

modular-magician · 2024-09-03T18:37:17Z

Tests analytics

Total tests: 74
Passed tests: 61
Skipped tests: 12
Affected tests: 1

Click here to see the affected service packages

cloudrun

cloudrunv2

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccCloudRunService_resourcesRequirements

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudRunV2Service_cloudrunv2ServiceWithResourcesRequirements

Get to know how VCR tests work

modular-magician · 2024-09-03T18:54:21Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudRunV2Service_cloudrunv2ServiceWithResourcesRequirements[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician · 2024-09-03T22:01:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 19 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 307 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 48 insertions(+))

modular-magician · 2024-09-03T22:06:16Z

Tests analytics

Total tests: 30
Passed tests: 23
Skipped tests: 7
Affected tests: 0

Click here to see the affected service packages

cloudrun

cloudrunv2

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccCloudRunService_resourcesRequirements
TestAccCloudRunV2Service_cloudrunv2ServiceWithResourcesRequirements
TestAccCloudRunV2Service_cloudrunv2ServiceWithResourcesRequirements
$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

modular-magician · 2024-09-03T22:33:02Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 19 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 243 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 48 insertions(+))

modular-magician · 2024-09-03T22:38:41Z

Tests analytics

Total tests: 76
Passed tests: 63
Skipped tests: 12
Affected tests: 1

Click here to see the affected service packages

cloudrunv2

cloudrun

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccCloudRunService_resourcesRequirements

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudRunV2Service_cloudrunv2ServiceWithResourcesRequirements

Get to know how VCR tests work

modular-magician · 2024-09-03T22:39:35Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudRunV2Service_cloudrunv2ServiceWithResourcesRequirements[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

shuyama1 · 2024-09-04T02:12:28Z

mmv1/products/cloudrunv2/Service.yaml

+        description: Node Selector describes the hardware requirements of the resources.
+        properties:
+          - !ruby/object:Api::Type::String
+            name: 'accelerator'


Can we make this field required, given this is the only subfield under node_selector currently. We'd generally want to prevent users sending empty blocks.

If different fields are added later and all are optional, is it a breaking change to remove required on accelerator?

Nope, required -> optional is non-breaking

shuyama1 · 2024-09-04T02:16:03Z

mmv1/third_party/terraform/services/cloudrun/resource_cloud_run_service_test.go.erb

+<% unless version == 'ga' -%>
+
+func TestAccCloudRunService_resourcesRequirements(t *testing.T) {
+	acctest.SkipIfVcr(t)


Is there any particular reason that we need to skip VCR for this test?

Thanks for catching. I have removed these tests in favor of the examples.

shuyama1 · 2024-09-04T02:24:47Z

mmv1/templates/terraform/examples/cloud_run_service_gpu.tf.erb

@@ -0,0 +1,34 @@
+resource "google_cloud_run_service" "<%= ctx[:primary_resource_id] %>" {


We'll need to add an example block to the resource.yaml file to register this example for documentation and test case generation. Please refer to step 5 in https://googlecloudplatform.github.io/magic-modules/develop/test/test/#add-a-create-test for guidance. Additionally, we can remove the handwritten test since the resource configurations in the examples and the handwritten test are mostly identical.

Thanks. I have removed the tests in favor of the examples.

modular-magician · 2024-09-11T23:02:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 217 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 8 files changed, 546 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 48 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 128 insertions(+))

modular-magician · 2024-09-11T23:07:55Z

Tests analytics

Total tests: 79
Passed tests: 67
Skipped tests: 11
Affected tests: 1

Click here to see the affected service packages

cloudrunv2

cloudrun

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudRunService_resourcesRequirements

Get to know how VCR tests work

modular-magician · 2024-09-11T23:11:04Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudRunService_resourcesRequirements[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

jasonsmithio · 2024-09-13T20:53:20Z

Howdy!

I love this. Is this ready for review and merging? Happy to help if anything else is needed.

github-actions · 2024-09-16T09:42:57Z

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

shuyama1

LGTM overall, only a small comment regarding the example version

mmv1/products/cloudrun/Service.yaml

mmv1/products/cloudrunv2/Service.yaml

trshafer · 2024-09-17T17:04:48Z

LGTM overall, only a small comment regarding the example version

Thanks! I have applied the suggested fixes.

modular-magician · 2024-09-17T17:18:10Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 95 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 8 files changed, 546 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 48 insertions(+))

modular-magician · 2024-09-17T17:24:34Z

Tests analytics

Total tests: 79
Passed tests: 66
Skipped tests: 11
Affected tests: 2

Click here to see the affected service packages

cloudrun

cloudrunv2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudRunService_cloudRunServiceGpuExample

TestAccCloudRunV2Service_cloudrunv2ServiceGpuExample

Get to know how VCR tests work

modular-magician · 2024-09-17T17:24:48Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudRunService_cloudRunServiceGpuExample[Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceGpuExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

shuyama1

you'll need follow step 3 in https://googlecloudplatform.github.io/magic-modules/develop/test/test/#add-a-create-test to add provider = google-beta to every resource in your example configuration file. This should resolve the test failure. Sorry that I pointed to the wrong step in my previous comment.

Co-authored-by: Shuya Ma <[email protected]>

trshafer · 2024-09-18T15:57:09Z

Ah, thank you. I have updated the example files.

modular-magician · 2024-09-18T16:09:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 97 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 8 files changed, 550 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 48 insertions(+))

modular-magician · 2024-09-18T16:15:06Z

Tests analytics

Total tests: 79
Passed tests: 68
Skipped tests: 11
Affected tests: 0

Click here to see the affected service packages

cloudrun

cloudrunv2

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

…CloudPlatform#11597)

modular-magician added the service/run label Aug 30, 2024

modular-magician requested a review from nifflets August 30, 2024 21:35

trshafer force-pushed the gpu branch from 18d53c2 to c99e5f3 Compare August 30, 2024 21:59

trshafer marked this pull request as ready for review August 30, 2024 22:16

github-actions bot requested a review from shuyama1 August 30, 2024 22:16

trshafer force-pushed the gpu branch from c99e5f3 to 87ca3ee Compare September 3, 2024 16:23

trshafer force-pushed the gpu branch from 87ca3ee to 39996ac Compare September 3, 2024 18:20

trshafer force-pushed the gpu branch from 39996ac to 1d06d3b Compare September 3, 2024 21:48

trshafer force-pushed the gpu branch from 1d06d3b to 011840c Compare September 3, 2024 22:21

shuyama1 reviewed Sep 4, 2024

View reviewed changes

trshafer force-pushed the gpu branch from 011840c to 4f81080 Compare September 5, 2024 19:52

github-actions bot requested a review from shuyama1 September 5, 2024 19:53

shuyama1 reviewed Sep 16, 2024

View reviewed changes

mmv1/products/cloudrun/Service.yaml Outdated Show resolved Hide resolved

mmv1/products/cloudrunv2/Service.yaml Outdated Show resolved Hide resolved

github-actions bot requested a review from shuyama1 September 17, 2024 17:04

shuyama1 reviewed Sep 17, 2024

View reviewed changes

trshafer and others added 5 commits September 18, 2024 15:56

Add node selector and gpu support with tests to Cloud Run Service v1 api

7aa87f3

Add node selector and gpu support with tests to Cloud Run Service v2 api

1993daf

Update mmv1/products/cloudrunv2/Service.yaml

60bfb18

Co-authored-by: Shuya Ma <[email protected]>

Update mmv1/products/cloudrun/Service.yaml

3ed0a83

Co-authored-by: Shuya Ma <[email protected]>

add google-beta to each example

6bf55c2

trshafer force-pushed the gpu branch from 808f52b to 6bf55c2 Compare September 18, 2024 15:56

github-actions bot requested a review from shuyama1 September 18, 2024 15:57

shuyama1 approved these changes Sep 19, 2024

View reviewed changes

shuyama1 merged commit c0c09b2 into GoogleCloudPlatform:main Sep 19, 2024
13 checks passed

abd-goog pushed a commit to abd-goog/magic-modules that referenced this pull request Sep 23, 2024

Add support for GPU fields in Cloud Run Service v1 and v2 api (Google…

26cb88a

…CloudPlatform#11597)

niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024

Add support for GPU fields in Cloud Run Service v1 and v2 api (Google…

75768c7

…CloudPlatform#11597)

Philip-Jonany pushed a commit to Philip-Jonany/magic-modules that referenced this pull request Nov 4, 2024

Add support for GPU fields in Cloud Run Service v1 and v2 api (Google…

ba502fc

…CloudPlatform#11597)

		@@ -0,0 +1,34 @@
		resource "google_cloud_run_service" "<%= ctx[:primary_resource_id] %>" {

Add support for GPU fields in Cloud Run Service v1 and v2 api #11597

Add support for GPU fields in Cloud Run Service v1 and v2 api #11597

Conversation

trshafer commented Aug 30, 2024 • edited Loading

modular-magician commented Aug 30, 2024

Diff report

modular-magician commented Aug 30, 2024

Tests analytics

Action taken

modular-magician commented Aug 30, 2024

modular-magician commented Aug 30, 2024

Diff report

github-actions bot commented Aug 30, 2024

modular-magician commented Aug 30, 2024

Tests analytics

Action taken

modular-magician commented Aug 30, 2024

modular-magician commented Sep 3, 2024

Diff report

modular-magician commented Sep 3, 2024

Tests analytics

Action taken

modular-magician commented Sep 3, 2024

modular-magician commented Sep 3, 2024

Diff report

modular-magician commented Sep 3, 2024

Tests analytics

Action taken

modular-magician commented Sep 3, 2024

modular-magician commented Sep 3, 2024

Diff report

modular-magician commented Sep 3, 2024

Tests analytics

modular-magician commented Sep 3, 2024

Diff report

modular-magician commented Sep 3, 2024

Tests analytics

Action taken

modular-magician commented Sep 3, 2024

shuyama1 Sep 4, 2024

Choose a reason for hiding this comment

trshafer Sep 5, 2024

Choose a reason for hiding this comment

shuyama1 Sep 5, 2024

Choose a reason for hiding this comment

shuyama1 Sep 4, 2024

Choose a reason for hiding this comment

trshafer Sep 5, 2024

Choose a reason for hiding this comment

shuyama1 Sep 4, 2024

Choose a reason for hiding this comment

trshafer Sep 5, 2024

Choose a reason for hiding this comment

modular-magician commented Sep 11, 2024

Diff report

modular-magician commented Sep 11, 2024

Tests analytics

Action taken

modular-magician commented Sep 11, 2024

jasonsmithio commented Sep 13, 2024

github-actions bot commented Sep 16, 2024

shuyama1 left a comment

Choose a reason for hiding this comment

trshafer commented Sep 17, 2024

modular-magician commented Sep 17, 2024

Diff report

modular-magician commented Sep 17, 2024

Tests analytics

Action taken

modular-magician commented Sep 17, 2024

shuyama1 left a comment

Choose a reason for hiding this comment

trshafer commented Sep 18, 2024

modular-magician commented Sep 18, 2024

Diff report

modular-magician commented Sep 18, 2024

Tests analytics

trshafer commented Aug 30, 2024 •

edited

Loading