-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
container: Add node_kublet_config
support for autopilot clusters
#11573
container: Add node_kublet_config
support for autopilot clusters
#11573
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
a63b620
to
9d04dc2
Compare
mmv1/third_party/terraform/services/container/resource_container_cluster_test.go.erb
Outdated
Show resolved
Hide resolved
9d04dc2
to
d943789
Compare
Add support for `node_kubelet_config` in `node_pool_auto_config`. See: hashicorp/terraform-provider-google#15208 (comment) Per: https://pkg.go.dev/google.golang.org/api/container/v1#NodePoolAutoConfig Currently only `insecure_kubelet_readonly_port_enabled` can be set here. Fixes hashicorp/terraform-provider-google#19236 Fixes hashicorp/terraform-provider-google#19153
d943789
to
616cb89
Compare
mmv1/third_party/terraform/services/container/resource_container_cluster.go.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/container/resource_container_cluster.go.erb
Outdated
Show resolved
Hide resolved
Tests analyticsTotal tests: 204 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
mmv1/third_party/terraform/services/container/resource_container_cluster.go.erb
Outdated
Show resolved
Hide resolved
Tests analyticsTotal tests: 204 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
mmv1/third_party/terraform/website/docs/r/container_cluster.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/container_cluster.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/container_cluster.html.markdown
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 204 Click here to see the affected service packages
View the build log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…oogleCloudPlatform#11573) Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Add support for
node_kubelet_config
innode_pool_auto_config
.See:
hashicorp/terraform-provider-google#15208 (comment)
Per:
https://pkg.go.dev/google.golang.org/api/container/v1#NodePoolAutoConfig Currently only
insecure_kubelet_readonly_port_enabled
can be set here. I'm not sure what the future plans are, and whether the provider should allow the other set of flags to be set; otherwise, we may have to adjust some of this so that only supported parameters are allowed.Fixes hashicorp/terraform-provider-google#19236
Fixes hashicorp/terraform-provider-google#19153
Release Note Template for Downstream PRs (will be copied)