Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container: Add node_kublet_config support for autopilot clusters #11573

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Aug 29, 2024

Add support for node_kubelet_config in node_pool_auto_config.

See:
hashicorp/terraform-provider-google#15208 (comment)

Per:
https://pkg.go.dev/google.golang.org/api/container/v1#NodePoolAutoConfig Currently only insecure_kubelet_readonly_port_enabled can be set here. I'm not sure what the future plans are, and whether the provider should allow the other set of flags to be set; otherwise, we may have to adjust some of this so that only supported parameters are allowed.

Fixes hashicorp/terraform-provider-google#19236
Fixes hashicorp/terraform-provider-google#19153

Release Note Template for Downstream PRs (will be copied)

container: Add `node_kublet_config` support for autopilot clusters.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 29, 2024
@wyardley wyardley marked this pull request as ready for review August 29, 2024 04:42
@github-actions github-actions bot requested a review from melinath August 29, 2024 04:43
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@wyardley wyardley force-pushed the wyardley/19236/autopilot_kubelet_config branch from a63b620 to 9d04dc2 Compare August 29, 2024 04:55
@wyardley wyardley force-pushed the wyardley/19236/autopilot_kubelet_config branch from 9d04dc2 to d943789 Compare August 29, 2024 05:03
@wyardley wyardley force-pushed the wyardley/19236/autopilot_kubelet_config branch from d943789 to 616cb89 Compare August 29, 2024 05:40
@github-actions github-actions bot requested a review from melinath August 29, 2024 16:14
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 29, 2024
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Aug 29, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 121 insertions(+))
google-beta provider: Diff ( 4 files changed, 121 insertions(+))

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 29, 2024
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 204
Passed tests: 190
Skipped tests: 13
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_withAutopilotKubeletConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Several tests got terminated during RECORDING mode.}}$
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 29, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 135 insertions(+))
google-beta provider: Diff ( 4 files changed, 135 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 204
Passed tests: 190
Skipped tests: 13
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_withAutopilotKubeletConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerCluster_withAutopilotKubeletConfig[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from melinath August 29, 2024 21:37
@github-actions github-actions bot requested a review from melinath August 29, 2024 21:38
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Aug 29, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 137 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 137 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 204
Passed tests: 191
Skipped tests: 13
Affected tests: 0

Click here to see the affected service packages
  • container

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melinath melinath merged commit bba168c into GoogleCloudPlatform:main Aug 29, 2024
9 of 10 checks passed
iyabchen pushed a commit to iyabchen/magic-modules that referenced this pull request Sep 14, 2024
@wyardley wyardley deleted the wyardley/19236/autopilot_kubelet_config branch September 25, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants