Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terraform]: Restore the deprecated list splat syntax. #1156

Conversation

rileykarson
Copy link
Member

hashicorp/terraform#14737 deprecated the syntax we were using in a few places, but switching our tests over leads to the following error:

------- Stdout: -------
=== RUN   TestAccComputeInstanceGroup_recreatedInstances
--- FAIL: TestAccComputeInstanceGroup_recreatedInstances (0.03s)
	testing.go:538: Step 0 error: config is invalid: google_compute_instance_group.update: instances: should be a list
FAIL

This change restores the old syntax. The old syntax is going away in 0.12, so we'll need to revert this change before an update.


[all]

[terraform]

Restore the deprecated list splat syntax.

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#314
depends: hashicorp/terraform-provider-google#2801

rileykarson and others added 2 commits January 4, 2019 21:38
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
@modular-magician modular-magician force-pushed the restore-deprecated-0.11-interpolation branch from d53f076 to eb4257a Compare January 4, 2019 21:38
@modular-magician modular-magician merged commit f0c89a3 into GoogleCloudPlatform:master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants