Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resource V2 SCC Findings Export to Big Query Folder Config #11517

Conversation

vijaykanthm
Copy link
Contributor

Related to http://b/356159589.

Bug Description: hashicorp/terraform-provider-google#18848

Adding new template for V2 SCC Findings Exports to Big Query Folder Config
https://cloud.google.com/security-command-center/docs/reference/rest/v2/folders.locations.bigQueryExports

Release Note Template for Downstream PRs (will be copied)

`google_scc_v2_folder_scc_big_query_exports`

@github-actions github-actions bot requested a review from SarahFrench August 21, 2024 18:24
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/securitycenter and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Aug 21, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 993 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 993 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 99 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_v2_folder_scc_big_query_exports (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_folder_scc_big_query_exports" "primary" {
  name = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 14
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • securitycenterv2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityCenterV2FolderBigQueryExportConfig_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecurityCenterV2FolderBigQueryExportConfig_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 22, 2024
Copy link

@SarahFrench This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SarahFrench This PR has been waiting for review for 3 weekdays. Please take a look!

I'm OOO and will review this on Tuesday

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 27, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 999 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 999 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 99 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_v2_folder_scc_big_query_exports (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_folder_scc_big_query_exports" "primary" {
  name = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 14
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • securitycenterv2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityCenterV2FolderBigQueryExportConfig_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSecurityCenterV2FolderBigQueryExportConfig_basic[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

Copy link
Contributor

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! I've left some comments about some improvements and clarifications

url_param_only: true
default_value: global
description: |
location Id is provided by organization. If not provided, Use global as default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the location value need to match the location of the destination dataset? I find the first part of this description a bit ambiguous

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot requested a review from SarahFrench August 27, 2024 19:07
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 27, 2024
@vijaykanthm
Copy link
Contributor Author

Hi @SarahFrench, I have addressed the comments can you please review the PR again. Thanks.

Copy link

@SarahFrench This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 30, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 970 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 970 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • securitycenterv2
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterV2FolderBigQueryExportConfig_basic
    $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

…scc_v2_folder_big_query_export_config_test.go
@github-actions github-actions bot requested a review from SarahFrench August 30, 2024 11:56
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 969 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 969 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 16
Passed tests: 15
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • securitycenterv2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityCenterV2FolderBigQueryExportConfig_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSecurityCenterV2FolderBigQueryExportConfig_basic[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 969 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 969 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 16
Passed tests: 16
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • securitycenterv2

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@vijaykanthm
Copy link
Contributor Author

Hi Sarah, thank you for the review, looks like all the checks are passed except terraform-google-conversion-build-and-unit-tests, I had the same for the other PR and the reviewer for it has informed that it is broken due to 6.0 release upgrade and not because of the my code, just an fyi.

Copy link
Contributor

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants