Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial fix #11500

Conversation

maxi-cit
Copy link
Contributor

Fixes: hashicorp/terraform-provider-google#18793

Fixes an issue regarding GKE Resource Manager Tags which was causing in-place update due to not handling null values properly

Release Note Template for Downstream PRs (will be copied)

container: fixed update inconsistency in `google_container_cluster`

@github-actions github-actions bot requested a review from BBBmau August 20, 2024 18:10
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/container and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Aug 20, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 11 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 11 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 200
Passed tests: 190
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages
  • container

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Copy link

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Collaborator

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for adding these checks!

@BBBmau BBBmau merged commit 723d418 into GoogleCloudPlatform:main Aug 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent resource_manager_tags behavior on google_container_cluster
3 participants