Add deletion_protection to v2 cloud run service resource #11318
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_cloud_run_v2_job" "primary" {
deletion_protection = # value needed
}
Resource: resource "google_cloud_run_v2_service" "primary" {
deletion_protection = # value needed
}
|
Tests analyticsTotal tests: 43 Click here to see the affected service packages
Action takenFound 43 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_cloud_run_v2_job" "primary" {
deletion_protection = # value needed
}
Resource: resource "google_cloud_run_v2_service" "primary" {
deletion_protection = # value needed
}
|
Tests analyticsTotal tests: 43 Click here to see the affected service packages
Action takenFound 39 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 43 Click here to see the affected service packages
Action takenFound 38 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 43 Click here to see the affected service packages
Action takenFound 38 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 43 Click here to see the affected service packages
Action takenFound 32 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 43 Click here to see the affected service packages
Action takenFound 32 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
|
…run_v2_service_test.go.erb Co-authored-by: Thomas Rodgers <[email protected]>
…run_v2_service_test.go.erb Co-authored-by: Thomas Rodgers <[email protected]>
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
1 similar comment
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 43 Click here to see the affected service packages
View the build log |
Tests analyticsTotal tests: 43 Click here to see the affected service packages
View the build log |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 43 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 43 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
|
|
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 43 Click here to see the affected service packages
View the build log |
trodge
merged commit 1c7aa4d
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-6.0.0
|
hello. not sure if this is the right place for such a question but i'll give it a try: i guess pinning the provider version was also not the best idea but the issue remains the same |
|
Hi @trodge, it's not clear if applying a template with protection set to false is sufficient, or if it needs first an apply then a delete ? |
|
@emilecaron do you have some feedbacks about your usage ? Does protection to false on destroy is sufficient ? |
|
You must first remove delete protection then delete it. Can't work in a
single apply, which is kinda breaking when some resources have to be
recreated on every deployment
Le mar. 17 déc. 2024, 19:12, Antoine Cormouls ***@***.***> a
écrit :
… @emilecaron <https://github.com/emilecaron> do you have some feedbacks
about your usage ? Does protection to false on destroy is sufficient ?
—
Reply to this email directly, view it on GitHub
<#11318 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABPUBD7BA4IRWRYK75Z7ZZD2GBEOPAVCNFSM6AAAAABLZIV7JCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBYHEYDOMJTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
thanks @emilecaron for your answer, we tested the change on staging on a old ressource, if we trigger the destroy with the new provider version (from a old state of old provider) it works. |
Add deletion_protection to v2 cloud run service resource
b/317099814
Release Note Template for Downstream PRs (will be copied)