Add deprecation message for skip_delete for Project resource

[abd-goog]

Add deprecation message for skip_delete for Project resource.
Part of b/330143705

Part of hashicorp/terraform-provider-google#18775

Release Note Template for Downstream PRs (will be copied)

'skip_delete' is being deprecated in favor of a new field 'deletion_policy' in the next major release

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 2 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 2 insertions(+), 1 deletion(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• resourcemanager

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 2 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 2 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_project (867 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_project" "primary" {
  skip_delete = # value needed
}

[modular-magician]

Tests analytics

Total tests: 142
Passed tests: 111
Skipped tests: 31
Affected tests: 0

Click here to see the affected service packages

• resourcemanager

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 2 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 2 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_project (867 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_project" "primary" {
  skip_delete = # value needed
}

[modular-magician]

Tests analytics

Total tests: 142
Passed tests: 111
Skipped tests: 31
Affected tests: 0

Click here to see the affected service packages

• resourcemanager

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[slevenick]

I think you can remove quotation marks in this message and it should fix the compilation error

[abd-goog]

Thanks, removed quotation marks. Doesn't seem to help though.

[abd-goog]

Locally the provider generation works fine. There's something wrong with the test, it's picking up older version perhaps.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 2 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 2 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_project (867 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_project" "primary" {
  skip_delete = # value needed
}

[modular-magician]

Tests analytics

Total tests: 142
Passed tests: 111
Skipped tests: 31
Affected tests: 0

Click here to see the affected service packages

• resourcemanager

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[slevenick]

@melinath do you know why TGC would be failing for this change? It doesn't seem like it should be causing a failure

[melinath]

This is caused by hashicorp/terraform-provider-google#17924 - rerunning the tests should resolve it. (#10671 will fix it more permanently.) /gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 2 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 2 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_project (867 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_project" "primary" {
  skip_delete = # value needed
}

[modular-magician]

Tests analytics

Total tests: 142
Passed tests: 111
Skipped tests: 31
Affected tests: 0

Click here to see the affected service packages

• resourcemanager

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log