google_datastore_index: Deprecate

[rwhogg]

It's redundant with google_firestore_index, and the fact that it only supports the (default) database means that we get annoying test failures when the test runs more than once in a five-minute period or if the database doesn't get deleted correctly for whatever reason.

Googlers: see b/243079146

Release Note Template for Downstream PRs (will be copied)

datastore: deprecated the resource `google_datastore_index`. Use the `google_firestore_index` resource instead.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 18 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 3 files changed, 18 insertions(+), 12 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1
Passed tests: 1
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• datastore

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.