Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding delay after SecuritySettings create to work around API inconsistency #11165

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

mmurakowski-verily
Copy link
Contributor

@mmurakowski-verily mmurakowski-verily commented Jul 15, 2024

What it says on the tin. The create POST returns an ID that isn't always immediately GETable. Let's wait a few seconds and hope that fixes it.

Fixes hashicorp/terraform-provider-google#18735

Release Note Template for Downstream PRs (will be copied)

dialogflowcx: fixed intermittent issues with retrieving resource state soon after creating `google_dialogflow_cx_security_settings` resources

@github-actions github-actions bot requested a review from NickElliot July 15, 2024 17:58
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 5 insertions(+))
google-beta provider: Diff ( 1 file changed, 5 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 29
Passed tests: 29
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • dialogflowcx

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Copy link

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_dialogflow_cx_security_settings isn't consistently create-able
3 participants