-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KMS
: add plural data source for resource_google_kms_key_ring
#11061
KMS
: add plural data source for resource_google_kms_key_ring
#11061
Conversation
Tests analyticsTotal tests: 36 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Tests analyticsTotal tests: 36 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
mmv1/third_party/terraform/services/kms/data_source_google_kms_key_rings.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/kms/data_source_google_kms_key_rings.go
Show resolved
Hide resolved
…_key_rings.go Co-authored-by: Sarah French <[email protected]>
Tests analyticsTotal tests: 36 Click here to see the affected service packages
View the build log |
latest commit adds The following is the output as well as the tfconfig that produces it:
data "google_kms_key_rings" "mau" {
location = "global"
}
...
{
"id" = "projects/hc-terraform-testing/locations/global/keyRings/tf-test-keyring-exampleksrf4q2e41"
"name" = "tf-test-keyring-exampleksrf4q2e41"
},
{
"id" = "projects/hc-terraform-testing/locations/global/keyRings/tf-test-keyring-exampleml7ke81gcw"
"name" = "tf-test-keyring-exampleml7ke81gcw"
},
])
"location" = "global"
"project" = "hc-terraform-testing"
} @SarahFrench should be ready after VCR tests pass 👍🏼 |
Tests analyticsTotal tests: 36 Click here to see the affected service packages
View the build log |
e87f656
to
ee23c50
Compare
recent commit adds the recent pushes from #11053 which allows the 429 error to be handled. |
Tests analyticsTotal tests: 37 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but please accept the suggestions and allow tests to finish before merging!
mmv1/third_party/terraform/services/kms/data_source_google_kms_key_rings.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/kms/data_source_google_kms_key_rings_test.go
Outdated
Show resolved
Hide resolved
…_key_rings.go Co-authored-by: Sarah French <[email protected]>
…_key_rings_test.go Co-authored-by: Sarah French <[email protected]>
Tests analyticsTotal tests: 37 Click here to see the affected service packages
View the build log |
Tests analyticsTotal tests: 37 Click here to see the affected service packages
View the build log |
…gleCloudPlatform#11061) Co-authored-by: Sarah French <[email protected]>
…gleCloudPlatform#11061) Co-authored-by: Sarah French <[email protected]>
…gleCloudPlatform#11061) Co-authored-by: Sarah French <[email protected]>
This PR adds a new plural data source
google_kms_key_rings
.Note:
id
field to the schema for each individual key ring. Similar behavior also appears here: Add plural data sourcegoogle_kms_crypto_keys
#11053createTime
. Only reason why this wasn't ended in this PR is due the attribute not being included inresource_google_kms_key_ring.go
Running locally:
Release Note Template for Downstream PRs (will be copied)