AccessContextManager - Add dry run version of Ingress / Egress policy resources. #10990

Charlesleonius · 2024-06-17T23:20:20Z

Added ServicePerimeterDryRunEgressPolicy and ServicePerimeterDryRunIngressPolicy to support managing individual ingress and egress policies in the dry-run configuration of service perimeters.

Addresses:
b/335474574 - #17864

`google_access_context_manager_service_perimeter_dry_run_ingress_policy`

`google_access_context_manager_service_perimeter_dry_run_egress_policy`

github-actions · 2024-06-17T23:20:59Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2024-06-17T23:31:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2679 insertions(+), 20 deletions(-))
google-beta provider: Diff ( 10 files changed, 2679 insertions(+), 20 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_dry_run_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
  egress_from {
    identities         = # value needed
    identity_type      = # value needed
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
  egress_to {
    external_resources = # value needed
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

Resource: google_access_context_manager_service_perimeter_dry_run_ingress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_ingress_policy" "primary" {
  ingress_from {
    identities    = # value needed
    identity_type = # value needed
    sources {
      access_level = # value needed
      resource     = # value needed
    }
  }
  ingress_to {
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

modular-magician · 2024-06-17T23:37:51Z

Tests analytics

Total tests: 4
Passed tests: 1
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

modular-magician · 2024-06-18T19:06:56Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2679 insertions(+), 20 deletions(-))
google-beta provider: Diff ( 10 files changed, 2679 insertions(+), 20 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_dry_run_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
  egress_from {
    identities         = # value needed
    identity_type      = # value needed
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
  egress_to {
    external_resources = # value needed
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

Resource: google_access_context_manager_service_perimeter_dry_run_ingress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_ingress_policy" "primary" {
  ingress_from {
    identities    = # value needed
    identity_type = # value needed
    sources {
      access_level = # value needed
      resource     = # value needed
    }
  }
  ingress_to {
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

modular-magician · 2024-06-18T19:13:28Z

Tests analytics

Total tests: 4
Passed tests: 1
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

modular-magician · 2024-06-18T19:38:17Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2679 insertions(+), 20 deletions(-))
google-beta provider: Diff ( 10 files changed, 2679 insertions(+), 20 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_dry_run_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
  egress_from {
    identities         = # value needed
    identity_type      = # value needed
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
  egress_to {
    external_resources = # value needed
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

Resource: google_access_context_manager_service_perimeter_dry_run_ingress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_ingress_policy" "primary" {
  ingress_from {
    identities    = # value needed
    identity_type = # value needed
    sources {
      access_level = # value needed
      resource     = # value needed
    }
  }
  ingress_to {
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

modular-magician · 2024-06-18T19:39:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2679 insertions(+), 20 deletions(-))
google-beta provider: Diff ( 10 files changed, 2679 insertions(+), 20 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_dry_run_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
  egress_from {
    identities         = # value needed
    identity_type      = # value needed
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
  egress_to {
    external_resources = # value needed
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

Resource: google_access_context_manager_service_perimeter_dry_run_ingress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_ingress_policy" "primary" {
  ingress_from {
    identities    = # value needed
    identity_type = # value needed
    sources {
      access_level = # value needed
      resource     = # value needed
    }
  }
  ingress_to {
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

modular-magician · 2024-06-18T19:41:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2679 insertions(+), 20 deletions(-))
google-beta provider: Diff ( 10 files changed, 2679 insertions(+), 20 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_dry_run_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
  egress_from {
    identities         = # value needed
    identity_type      = # value needed
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
  egress_to {
    external_resources = # value needed
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

Resource: google_access_context_manager_service_perimeter_dry_run_ingress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_ingress_policy" "primary" {
  ingress_from {
    identities    = # value needed
    identity_type = # value needed
    sources {
      access_level = # value needed
      resource     = # value needed
    }
  }
  ingress_to {
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

modular-magician · 2024-06-18T19:44:14Z

Tests analytics

Total tests: 4
Passed tests: 1
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

modular-magician · 2024-06-18T19:46:02Z

Tests analytics

Total tests: 4
Passed tests: 1
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

modular-magician · 2024-06-18T19:48:18Z

Tests analytics

Total tests: 4
Passed tests: 1
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

github-actions · 2024-06-20T09:40:40Z

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2024-06-24T09:40:50Z

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2024-07-01T09:41:03Z

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

mmv1/products/accesscontextmanager/ServicePerimeterDryRunEgressPolicy.yaml

...ntextmanager/resource_access_context_manager_service_perimeter_dry_run_egress_policy_test.go

Charlesleonius · 2024-07-08T20:53:13Z

@rileykarson I added exclude_import for the new resources and the existing ones and then removed the import step from the tests. Should that suffice?

modular-magician · 2024-07-08T21:00:37Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 2595 insertions(+), 108 deletions(-))
google-beta provider: Diff ( 14 files changed, 2595 insertions(+), 108 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_dry_run_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
  egress_from {
    identities         = # value needed
    identity_type      = # value needed
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
  egress_to {
    external_resources = # value needed
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

Resource: google_access_context_manager_service_perimeter_dry_run_ingress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_ingress_policy" "primary" {
  ingress_from {
    identities    = # value needed
    identity_type = # value needed
    sources {
      access_level = # value needed
      resource     = # value needed
    }
  }
  ingress_to {
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

modular-magician · 2024-07-08T21:05:01Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 2595 insertions(+), 108 deletions(-))
google-beta provider: Diff ( 14 files changed, 2595 insertions(+), 108 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_dry_run_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
  egress_from {
    identities         = # value needed
    identity_type      = # value needed
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
  egress_to {
    external_resources = # value needed
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

Resource: google_access_context_manager_service_perimeter_dry_run_ingress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_ingress_policy" "primary" {
  ingress_from {
    identities    = # value needed
    identity_type = # value needed
    sources {
      access_level = # value needed
      resource     = # value needed
    }
  }
  ingress_to {
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

modular-magician · 2024-07-08T21:07:24Z

Tests analytics

Total tests: 4
Passed tests: 1
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

modular-magician · 2024-07-08T21:10:51Z

Tests analytics

Total tests: 4
Passed tests: 1
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

modular-magician · 2024-08-01T20:16:11Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 2612 insertions(+), 123 deletions(-))
google-beta provider: Diff ( 18 files changed, 2612 insertions(+), 123 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_dry_run_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
  egress_from {
    identities         = # value needed
    identity_type      = # value needed
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
  egress_to {
    external_resources = # value needed
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

Resource: google_access_context_manager_service_perimeter_dry_run_ingress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_ingress_policy" "primary" {
  ingress_from {
    identities    = # value needed
    identity_type = # value needed
    sources {
      access_level = # value needed
      resource     = # value needed
    }
  }
  ingress_to {
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
  egress_from {
    source_restriction = # value needed
  }
}

Resource: google_access_context_manager_service_perimeters (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeters" "primary" {
  service_perimeters {
    spec {
      egress_policies {
        egress_from {
          source_restriction = # value needed
        }
      }
    }
  }
}

modular-magician · 2024-08-01T20:22:18Z

Tests analytics

Total tests: 4
Passed tests: 1
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

modular-magician · 2024-08-01T20:23:00Z

Tests analytics

Total tests: 4
Passed tests: 1
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

mmv1/products/accesscontextmanager/ServicePerimeterDryRunIngressPolicy.yaml

mmv1/products/accesscontextmanager/ServicePerimeterDryRunEgressPolicy.yaml

mmv1/products/accesscontextmanager/ServicePerimeter.yaml

slevenick · 2024-08-02T13:44:11Z

mmv1/products/accesscontextmanager/ServicePerimeterDryRunEgressPolicy.yaml

+        name: 'sourceRestriction'
+        description: 'Whether to enforce traffic restrictions based on `sources` field. If the `sources` field is non-empty, then this field must be set to `SOURCE_RESTRICTION_ENABLED`.'
+        values:
+          - :SOURCE_RESTRICTION_UNSPECIFIED


I'm still seeing this one

slevenick · 2024-08-02T13:45:20Z

...ntextmanager/resource_access_context_manager_service_perimeter_dry_run_egress_policy_test.go

+// can exist, they need to be run serially. See AccessPolicy for the test runner.
+
+func testAccAccessContextManagerServicePerimeterDryRunEgressPolicy_basicTest(t *testing.T) {
+	// Multiple fine-grained resources


It's useful to see that they can both exist at the same time without interfering with each other.

modular-magician · 2024-08-02T17:23:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 2608 insertions(+), 123 deletions(-))
google-beta provider: Diff ( 18 files changed, 2608 insertions(+), 123 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_dry_run_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
  egress_from {
    identities         = # value needed
    identity_type      = # value needed
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
  egress_to {
    external_resources = # value needed
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

Resource: google_access_context_manager_service_perimeter_dry_run_ingress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_ingress_policy" "primary" {
  ingress_from {
    identities    = # value needed
    identity_type = # value needed
    sources {
      access_level = # value needed
      resource     = # value needed
    }
  }
  ingress_to {
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
  egress_from {
    source_restriction = # value needed
  }
}

Resource: google_access_context_manager_service_perimeters (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeters" "primary" {
  service_perimeters {
    spec {
      egress_policies {
        egress_from {
          source_restriction = # value needed
        }
      }
    }
  }
}

modular-magician · 2024-08-02T17:30:33Z

Tests analytics

Total tests: 4
Passed tests: 0
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-08-02T17:31:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 2596 insertions(+), 111 deletions(-))
google-beta provider: Diff ( 14 files changed, 2596 insertions(+), 111 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_dry_run_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
  egress_from {
    identities         = # value needed
    identity_type      = # value needed
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
  egress_to {
    external_resources = # value needed
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

Resource: google_access_context_manager_service_perimeter_dry_run_ingress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_ingress_policy" "primary" {
  ingress_from {
    identities    = # value needed
    identity_type = # value needed
    sources {
      access_level = # value needed
      resource     = # value needed
    }
  }
  ingress_to {
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
  egress_from {
    source_restriction = # value needed
  }
}

modular-magician · 2024-08-02T17:37:51Z

Tests analytics

Total tests: 4
Passed tests: 0
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-08-02T17:41:51Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAccessContextManager[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician · 2024-08-02T17:44:29Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAccessContextManager[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Charlesleonius · 2024-08-05T16:58:20Z

Hello @slevenick, can you please run the VCR tests again.

slevenick · 2024-08-05T20:08:32Z

/gcbrun

modular-magician · 2024-08-05T20:21:09Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 2596 insertions(+), 111 deletions(-))
google-beta provider: Diff ( 14 files changed, 2596 insertions(+), 111 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_dry_run_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
  egress_from {
    identities         = # value needed
    identity_type      = # value needed
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
  egress_to {
    external_resources = # value needed
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

Resource: google_access_context_manager_service_perimeter_dry_run_ingress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_ingress_policy" "primary" {
  ingress_from {
    identities    = # value needed
    identity_type = # value needed
    sources {
      access_level = # value needed
      resource     = # value needed
    }
  }
  ingress_to {
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
  egress_from {
    source_restriction = # value needed
  }
}

modular-magician · 2024-08-05T20:27:23Z

Tests analytics

Total tests: 4
Passed tests: 1
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

…cy resources

modular-magician · 2024-08-05T21:09:16Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 2596 insertions(+), 111 deletions(-))
google-beta provider: Diff ( 14 files changed, 2596 insertions(+), 111 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_dry_run_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
  egress_from {
    identities         = # value needed
    identity_type      = # value needed
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
  egress_to {
    external_resources = # value needed
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

Resource: google_access_context_manager_service_perimeter_dry_run_ingress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_ingress_policy" "primary" {
  ingress_from {
    identities    = # value needed
    identity_type = # value needed
    sources {
      access_level = # value needed
      resource     = # value needed
    }
  }
  ingress_to {
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
  egress_from {
    source_restriction = # value needed
  }
}

modular-magician · 2024-08-05T21:15:55Z

Tests analytics

Total tests: 4
Passed tests: 1
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

modular-magician · 2024-08-05T21:21:47Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 2593 insertions(+), 108 deletions(-))
google-beta provider: Diff ( 14 files changed, 2593 insertions(+), 108 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_dry_run_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
  egress_from {
    identities         = # value needed
    identity_type      = # value needed
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
  egress_to {
    external_resources = # value needed
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

Resource: google_access_context_manager_service_perimeter_dry_run_ingress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_ingress_policy" "primary" {
  ingress_from {
    identities    = # value needed
    identity_type = # value needed
    sources {
      access_level = # value needed
      resource     = # value needed
    }
  }
  ingress_to {
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

Charlesleonius · 2024-08-05T21:22:03Z

@slevenick I believe all issues have been addressed now and tests are passing

modular-magician · 2024-08-05T21:28:26Z

Tests analytics

Total tests: 4
Passed tests: 1
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

… resources. (GoogleCloudPlatform#10990) Co-authored-by: Charlesleonius <[email protected]>

github-actions bot requested a review from rileykarson June 17, 2024 23:20

modular-magician added the service/accesscontextmanager label Jun 17, 2024

Charlesleonius force-pushed the b/335474574 branch 4 times, most recently from c0367c5 to e857648 Compare June 18, 2024 19:31

rileykarson reviewed Jul 2, 2024

View reviewed changes

mmv1/products/accesscontextmanager/ServicePerimeterDryRunEgressPolicy.yaml Show resolved Hide resolved

...ntextmanager/resource_access_context_manager_service_perimeter_dry_run_egress_policy_test.go Show resolved Hide resolved

Charlesleonius force-pushed the b/335474574 branch from e857648 to 6034a6b Compare July 8, 2024 20:49

github-actions bot requested a review from rileykarson July 8, 2024 20:50

Charlesleonius closed this Jul 8, 2024

Charlesleonius reopened this Jul 8, 2024

slevenick requested changes Aug 2, 2024

View reviewed changes

github-actions bot requested a review from slevenick August 2, 2024 17:11

Charlesleonius force-pushed the b/335474574 branch from dc9cdf3 to 8bd5408 Compare August 2, 2024 17:18

Charlesleonius force-pushed the b/335474574 branch from 8bd5408 to f62e901 Compare August 5, 2024 20:56

Add dry run version of access context manager ingress and egress poli…

9f75f7e

…cy resources

Charlesleonius force-pushed the b/335474574 branch from f62e901 to 9f75f7e Compare August 5, 2024 21:08

slevenick approved these changes Aug 5, 2024

View reviewed changes

slevenick merged commit c3ebf61 into GoogleCloudPlatform:main Aug 5, 2024
14 checks passed

This was referenced Aug 5, 2024

AccessContextManager - Add dry run version of Ingress / Egress policy resources. hashicorp/terraform-provider-google-beta#7882

Merged

AccessContextManager - Add dry run version of Ingress / Egress policy resources. hashicorp/terraform-provider-google#18994

Merged

rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 12, 2024

AccessContextManager - Add dry run version of Ingress / Egress policy…

7856172

… resources. (GoogleCloudPlatform#10990) Co-authored-by: Charlesleonius <[email protected]>

BBBmau pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 21, 2024

AccessContextManager - Add dry run version of Ingress / Egress policy…

a8a025a

… resources. (GoogleCloudPlatform#10990) Co-authored-by: Charlesleonius <[email protected]>

AccessContextManager - Add dry run version of Ingress / Egress policy resources. #10990

AccessContextManager - Add dry run version of Ingress / Egress policy resources. #10990

Conversation

Charlesleonius commented Jun 17, 2024 • edited by slevenick Loading

github-actions bot commented Jun 17, 2024

modular-magician commented Jun 17, 2024

Diff report

Missing test report

modular-magician commented Jun 17, 2024

Tests analytics

modular-magician commented Jun 18, 2024

Diff report

Missing test report

modular-magician commented Jun 18, 2024

Tests analytics

modular-magician commented Jun 18, 2024

Diff report

Missing test report

modular-magician commented Jun 18, 2024

Diff report

Missing test report

modular-magician commented Jun 18, 2024

Diff report

Missing test report

modular-magician commented Jun 18, 2024

Tests analytics

modular-magician commented Jun 18, 2024

Tests analytics

modular-magician commented Jun 18, 2024

Tests analytics

github-actions bot commented Jun 20, 2024

github-actions bot commented Jun 24, 2024

github-actions bot commented Jul 1, 2024

Charlesleonius commented Jul 8, 2024

modular-magician commented Jul 8, 2024

Diff report

Missing test report

modular-magician commented Jul 8, 2024

Diff report

Missing test report

modular-magician commented Jul 8, 2024

Tests analytics

modular-magician commented Jul 8, 2024

Tests analytics

modular-magician commented Aug 1, 2024

Diff report

Missing test report

modular-magician commented Aug 1, 2024

Tests analytics

modular-magician commented Aug 1, 2024

Tests analytics

slevenick Aug 2, 2024

Choose a reason for hiding this comment

slevenick Aug 2, 2024

Choose a reason for hiding this comment

modular-magician commented Aug 2, 2024

Diff report

Missing test report

modular-magician commented Aug 2, 2024

Tests analytics

Action taken

modular-magician commented Aug 2, 2024

Diff report

Missing test report

modular-magician commented Aug 2, 2024

Tests analytics

Action taken

modular-magician commented Aug 2, 2024

modular-magician commented Aug 2, 2024

Charlesleonius commented Aug 5, 2024

slevenick commented Aug 5, 2024

modular-magician commented Aug 5, 2024

Diff report

Missing test report

modular-magician commented Aug 5, 2024

Tests analytics

modular-magician commented Aug 5, 2024

Diff report

Missing test report

modular-magician commented Aug 5, 2024

Charlesleonius commented Jun 17, 2024 •

edited by slevenick

Loading