Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeouts on google_sql_database_instance to 90m #10960

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

rileykarson
Copy link
Member

------- Stdout: -------
=== RUN   TestAccSqlDatabaseInstance_basicClone
=== PAUSE TestAccSqlDatabaseInstance_basicClone
=== CONT  TestAccSqlDatabaseInstance_basicClone
    vcr_utils.go:152: Step 1/2 error: Error running apply: exit status 1
        Error: Error waiting for Create Instance: timeout while waiting for state to become 'DONE' (last state: 'RUNNING', timeout: 40m0s)
          with google_sql_database_instance.instance,
          on terraform_plugin_test.tf line 2, in resource "google_sql_database_instance" "instance":
           2: resource "google_sql_database_instance" "instance" {
--- FAIL: TestAccSqlDatabaseInstance_basicClone (2407.16s)
FAIL

Release Note Template for Downstream PRs (will be copied)

sql: increased timeouts on `google_sql_database_instance` to 90m to account for longer-running actions such as creation through cloning

@rileykarson rileykarson requested review from a team and roaks3 and removed request for a team June 13, 2024 19:48
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 94
Passed tests: 80
Skipped tests: 14
Affected tests: 0

Click here to see the affected service packages
  • sql

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants