Add tlsEarlyData support to TargetHttpsProxy.

[wu-bin]

Fixes hashicorp/terraform-provider-google#18421

Tests that I run:

make testacc TEST=./google/services/compute TESTARGS='-run=TestAccComputeTargetHttpsProxy_'

Release Note Template for Downstream PRs (will be copied)

compute: added `tlsEarlyData` field to `google_compute_target_https_proxy` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 38 insertions(+))
google-beta provider: Diff ( 3 files changed, 38 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 960
Passed tests: 878
Skipped tests: 74
Affected tests: 8

Click here to see the affected service packages

• compute

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeTargetHttpsProxy_certificateMap|TestAccComputeTargetHttpsProxy_targetHttpsProxyBasicExample|TestAccComputeTargetHttpsProxy_targetHttpsProxyCertificateManagerCertificateExample|TestAccComputeTargetHttpsProxy_targetHttpsProxyHttpKeepAliveTimeoutExample|TestAccComputeTargetHttpsProxy_targetHttpsProxyMtlsExample|TestAccComputeTargetHttpsProxy_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Debug log]
TestAccComputeTargetHttpsProxy_certificateMap[Debug log]
TestAccComputeTargetHttpsProxy_targetHttpsProxyBasicExample[Debug log]
TestAccComputeTargetHttpsProxy_targetHttpsProxyCertificateManagerCertificateExample[Debug log]
TestAccComputeTargetHttpsProxy_targetHttpsProxyHttpKeepAliveTimeoutExample[Debug log]
TestAccComputeTargetHttpsProxy_targetHttpsProxyMtlsExample[Debug log]
TestAccComputeTargetHttpsProxy_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 38 insertions(+))
google-beta provider: Diff ( 3 files changed, 38 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 11 insertions(+))

[modular-magician]

Tests analytics

Total tests: 960
Passed tests: 885
Skipped tests: 74
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[NickElliot]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 38 insertions(+))
google-beta provider: Diff ( 3 files changed, 38 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 11 insertions(+))

[modular-magician]

Tests analytics

Total tests: 960
Passed tests: 885
Skipped tests: 74
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[NickElliot]

test failure is unrelated and persistent in nightly -- LGTM

[NickElliot]

wait realized one thing, sorry about that

[NickElliot]

adding a new default value can be very undesired due to potential risk to user configs -- does this field have a server side default? if so it could be flagged as default_from_api: true with the default removed. otherwise, we should remove the default value entirely as the field is optional.

[Yashpandey4]

Ack, I can confirm that the server side default is automatically set to DISABLED. Using default_from_api: true makes sense here

[wu-bin]

Thank you both! Changed to default_from_api: true.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 37 insertions(+))
google-beta provider: Diff ( 3 files changed, 37 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 11 insertions(+))

[modular-magician]

Tests analytics

Total tests: 960
Passed tests: 878
Skipped tests: 74
Affected tests: 8

Click here to see the affected service packages

• compute

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeTargetHttpsProxy_certificateMap|TestAccComputeTargetHttpsProxy_targetHttpsProxyBasicExample|TestAccComputeTargetHttpsProxy_targetHttpsProxyCertificateManagerCertificateExample|TestAccComputeTargetHttpsProxy_targetHttpsProxyHttpKeepAliveTimeoutExample|TestAccComputeTargetHttpsProxy_targetHttpsProxyMtlsExample|TestAccComputeTargetHttpsProxy_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Debug log]
TestAccComputeTargetHttpsProxy_certificateMap[Debug log]
TestAccComputeTargetHttpsProxy_targetHttpsProxyBasicExample[Debug log]
TestAccComputeTargetHttpsProxy_targetHttpsProxyCertificateManagerCertificateExample[Debug log]
TestAccComputeTargetHttpsProxy_targetHttpsProxyHttpKeepAliveTimeoutExample[Debug log]
TestAccComputeTargetHttpsProxy_targetHttpsProxyMtlsExample[Debug log]
TestAccComputeTargetHttpsProxy_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 37 insertions(+))
google-beta provider: Diff ( 3 files changed, 37 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 960
Passed tests: 886
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[NickElliot]

LGTM :)

[wu-bin]

Thank you, @NickElliot !